Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go to 1.23.1 #3924

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Update go to 1.23.1 #3924

merged 1 commit into from
Sep 19, 2024

Conversation

michel-laterman
Copy link
Contributor

Update go to v1.23.1

@michel-laterman michel-laterman added enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team backport-8.x Automated backport to the 8.x branch with mergify labels Sep 19, 2024
@michel-laterman michel-laterman requested a review from a team as a code owner September 19, 2024 20:33
@michel-laterman michel-laterman mentioned this pull request Sep 19, 2024
Closed
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

ycombinator
ycombinator approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR but wouldn't our automation have put up the bump PR anyway? Just curious why you had to do this manually instead.

@michel-laterman
Copy link
Contributor Author

our automation is set to do updates to patch releases; we've been updating to the next minor releases manually (though there is probably a way to trigger the automation)

@michel-laterman michel-laterman merged commit 6c14449 into elastic:main Sep 19, 2024
8 checks passed
@michel-laterman michel-laterman deleted the go-1.23 branch September 19, 2024 21:28
mergify bot pushed a commit that referenced this pull request Sep 19, 2024
@michel-laterman @mergify
Update go to 1.23.1 (#3924)
c50d901 
(cherry picked from commit 6c14449)
@mergify mergify bot mentioned this pull request Sep 19, 2024
Merged
michel-laterman added a commit that referenced this pull request Sep 19, 2024
@mergify @michel-laterman
Update go to 1.23.1 (#3924) (#3926)
25261ab 
(cherry picked from commit 6c14449)

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees
No one assigned
Labels
backport-8.x Automated backport to the 8.x branch with mergify enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michel-laterman @ycombinator