add metric: docappender.blocked.add counter #219
Merged
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This monotonic counter increments every time Appender.Add detects that bulkItems channel length and capacity are equal before sending the created BulkIndexerItem to the channel. As bulkItems is a buffered channel, monitoring length and capacity allow us to detect possible blocking events when sending to the channel due to exhausted capacity. As Appender.Add could be called from multiple goroutines, we are not guaranteed that every time this metric is incremented the channel send will block, but should give us a reasonably approximated picture.
elastic-observability-automation
bot
added
the
safe-to-test
endorama
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This monotonic counter increments every time
Appender.Adddetects that
bulkItemschannel length and capacity areequal before sending the created BulkIndexerItem to the
channel.
As
bulkItemsis a buffered channel, monitoring length andcapacity allow us to detect possible blocking events when
sending to the channel due to exhausted capacity.
As
Appender.Addcould be called from multiple goroutines,we are not guaranteed that every time this metric is
incremented the channel send will block, but should give us
a reasonably approximated picture.