Skip to content

Transport: logger LogRoundTrip (check request and response is not nill) #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Transport: logger LogRoundTrip (check request and response is not nill) #208

wants to merge 4 commits into from

Conversation

tty2
Copy link
Contributor

@tty2 tty2 commented Dec 14, 2020

Proposal.

There could be nil pointer dereference in these methods.

Check if req, res and req.URL are not nil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tty2