fix: add explicit go directive #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A missing go directive can lead to inconsistent behaviour between go versions. See https://go.dev/doc/go1.17#missing-go-directive Add an explicit directive to target Go 1.17.
💚 Build Succeeded
Expand to view the summary
Build stats
|
As of Go 1.16 module-aware mode is enabled by default so GO111MODULE=on is no longer needed. See https://go.dev/doc/go1.16#go-command This should also help with forward compatibility as GOPATH and GO111MODULE will be removed in the future, See https://github.com/golang/go/wiki/GOPATH#deprecating-and-removing-gopath-development-mode
andrewkroh
reviewed
Jul 25, 2022
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
golint is deprecated and this is consistent with what we're doing in other repositories.
andrewkroh
approved these changes
Jul 25, 2022
|
/test |
1 similar comment
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A missing go directive can lead to inconsistent
behaviour between go versions.
See https://go.dev/doc/go1.17#missing-go-directive
Add an explicit directive to target Go 1.17.