Go and CI maintenance - update deps, Go #27
Conversation
File is very dated and the image it uses is no longer a supported OS by Go.
Don't run the staticcheck from the scripts because it needs to be conditional upon the Go version being used. That is, in order to use newer versions you need a newer Go. Add a linter comment to the generated code to ignore usages of syscall.Syscall. The Go team decided to no update existing code to use SyscallN so we will follow suit.
Certain GH checks are required in order to merge a PR. If you modify a `.md` file then the checks are not triggered and you cannot merge.
andrewkroh
force-pushed
the
project-maintenance
branch
from
8e23344 to
5f7efe0
Compare
|
If anyone reviewing this PR has access to update the required CI checks for the repo, then please do so. You can see that it is still checking for |
Hi @andrewkroh, We can create a single status check, which can be set as required. This check would depend on the matrix's outcome. Here is an example of such a single status check. This way, we can also handle the docs (*.md) paths. Here is an example workflow that sets the I will approve this, update the required status checks for now, and create a follow-up applying the previously mentioned patterns. |
@reakaleek That would awesome. Can you give me permissions to merge on this repo too (probably at the team level is best @elastic/sec-windows-platform)? |
@andrewkroh you should now have appropriate permissions |
|
@reakaleek It looks like there is some branch protection rule that is still preventing any merges.
|
The |
Remove appveyor and vagrant config.
Bump Go dependency versions.
Add testing with latest Go 1.22.x.
Fix staticcheck lint warnings as well as failure to execute under Go 1.22.
Remove GH action
path-ignores' because "test" is a required check. When you change only.mdor.asciidoc` then you cannot merge the PR because the checks are missing.