Use volume iterators to list volumes in windows #112
Conversation
| // all.bat?) | ||
| return e | ||
| } | ||
|
|
||
| var ( | ||
| modkernel32 = syscall.NewLazyDLL("kernel32.dll") | ||
| modpsapi = syscall.NewLazyDLL("psapi.dll") | ||
| modntdll = syscall.NewLazyDLL("ntdll.dll") | ||
| modadvapi32 = syscall.NewLazyDLL("advapi32.dll") |
There was a problem hiding this comment.
@andrewkroh I had to revert these lines by hand, recent go versions use windows.NewLazySystemDLL, but as this package is named windows it fails.
We should move these generated syscall wrappers to other submodule, or rename this one.
There was a problem hiding this comment.
What fails? It should be fine to import golang.org/x/sys/windows from within package windows. That might be a new dep that we didn't use previously though.
There was a problem hiding this comment.
The problem is that it generates this code here:
modkernel32 = NewLazySystemDLL("kernel32.dll")
modpsapi = NewLazySystemDLL("psapi.dll")
modntdll = NewLazySystemDLL("ntdll.dll")
modadvapi32 = NewLazySystemDLL("advapi32.dll")
And NewLazySystemDLL doesn't exist in this package.
It seems that because it has some special handling for packages named windows: https://github.com/golang/go/blob/go1.10.5/src/syscall/mksyscall_windows.go#L735
I have seen that adding -systemdll=false to the parameters of mksyscall_windows generates the same code as before. I am adding it by now.
|
With #111 we also got the type of filesystem, but we can try to obtain this info in any case also after this with https://docs.microsoft.com/en-us/windows/desktop/api/fileapi/nf-fileapi-getvolumeinformationw |
| // all.bat?) | ||
| return e | ||
| } | ||
|
|
||
| var ( | ||
| modkernel32 = syscall.NewLazyDLL("kernel32.dll") | ||
| modpsapi = syscall.NewLazyDLL("psapi.dll") | ||
| modntdll = syscall.NewLazyDLL("ntdll.dll") | ||
| modadvapi32 = syscall.NewLazyDLL("advapi32.dll") |
There was a problem hiding this comment.
What fails? It should be fine to import golang.org/x/sys/windows from within package windows. That might be a new dep that we didn't use previously though.
Without this setting, it generates the syscall file as if it were inside the `windows` package, with local references to functions there, what fails.
|
Thanks @andrewkroh for the fast review 🙂 |
GetLogicalDriveStringsdoesn't list filesystems that are mounted withaccess paths but don't have a drive letter. Use volume iterators to
list all volumes and obtain its access paths.
Reported on elastic/beats#8916