Update gosigar windows code to use gosigar/sys/windows package #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes elastic#53 (ProcStatus.PPID value is wrong on Windows). The code was incorrectly using `CreateToolhelp32Snapshot` + `Process32First`. This could have been fixed, but it would have required iterating over each process until finding the PPID of process we were interested it. Instead the code has been changed to use `NtQueryInformationProcess` to get the PPID given a process token. - Fixes elastic#6 (Get the cpu usage per core in Windows). I used `NtQuerySystemInformation` to collect the timing information on a per CPU basis. - Adds OS version checks to the functions that make certain WMI calls. The `Win32_Process` data is only available on Vista and newer. On XP and Win2003, these methods will return `ErrNotImplemented`. This will help address elastic/beats#1704. - Implements `Uptime.Get` for Windows. - Implements `Swap.Get` for Windows based on page file metrics. - Removes cgo usage for Windows. - Adds support to `github.com/gosigar/sys/windows` for querying and enabling privileges in a process token. This will help in addressing elastic/beats#1897.
andrewkroh
force-pushed
the
feature/sigar-windows-refactor
branch
from
6838318 to
5c03d42
Compare
Current coverage is 62.33% (diff: 65.97%)@@ master #55 diff @@
==========================================
Files 22 23 +1
Lines 2139 2299 +160
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1324 1433 +109
- Misses 642 658 +16
- Partials 173 208 +35
|
|
Wow, quite a cleanup. LGTM. |
|
Reference the gosigar changes in #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateToolhelp32Snapshot+Process32First. This could have been fixed, but it would have required iterating over each process until finding the PPID of process we were interested it. Instead the code has been changed to useNtQueryInformationProcessto get the PPID given a process token.NtQuerySystemInformationto collect the timing information on a per CPU basis.Win32_Processdata is only available on Vista and newer. On XP and Win2003, these methods will returnErrNotImplemented. This will help address Server 2003 - PID’s not recognized - Topbeat beats#1704.Uptime.Getfor Windows.Swap.Getfor Windows based on page file metrics.github.com/gosigar/sys/windowsfor querying and enabling privileges in a process token. This will help in addressing [TopBeat 1.2.3.] Can't access PID, even with correct rights. beats#1897.