Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

feat: adding liveness probe for kibana #575

Closed
wants to merge 2 commits into from
Closed

Conversation

beepdot
Copy link

@beepdot beepdot commented Apr 13, 2020

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Apr 13, 2020

💚 CLA has been signed

@jmlrt jmlrt added the enhancement New feature or request label Apr 17, 2020
@jmlrt
Copy link
Member

jmlrt commented Apr 20, 2020

Hi @keshavprasadms, thank you for this PR, Kibana liveness probe wasn't defined for purpose.
We need to study if we can use the same probe as for readiness.

Meanwhile can you sign the CLA?

@jmlrt jmlrt mentioned this pull request Apr 20, 2020
1 task
@beepdot
Copy link
Author

beepdot commented May 29, 2020

Hi @keshavprasadms, thank you for this PR, Kibana liveness probe wasn't defined for purpose.
We need to study if we can use the same probe as for readiness.

Meanwhile can you sign the CLA?

@jmlrt CLA signed. Please let me know why we cannot be using liveness probe?

@jmlrt
Copy link
Member

jmlrt commented May 29, 2020

cla/check

@jmlrt jmlrt added the kibana label Jul 13, 2020
@nikitakazantsev12
Copy link

nikitakazantsev12 commented Sep 2, 2020

Hi @keshavprasadms, thank you for this PR, Kibana liveness probe wasn't defined for purpose.
We need to study if we can use the same probe as for readiness.

Our practical experience shows, that we can use exactly the same probe as a liveness check (now we're achieving that patching existing Kibana-deployment of the Helm-chart).

We are using the following values at the moment:

        failureThreshold: 3
        initialDelaySeconds: 120
        periodSeconds: 10
        successThreshold: 1
        timeoutSeconds: 1

@botelastic
Copy link

botelastic bot commented Dec 1, 2020

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist.

@botelastic
Copy link

botelastic bot commented Dec 31, 2020

This PR has been automatically closed because it has not had recent activity since being marked as stale. Please reopen when work resumes.

@botelastic botelastic bot closed this Dec 31, 2020
@ecureuil
Copy link

ecureuil commented Jul 4, 2021

Hi, unfortunalately this PR was automatically closed but the feature is still missing. @jmlrt do you want I recreate it, please?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants