-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Metricbeat] Dont generate config if not enabled #767
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
cla/check |
jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ebuildy, thanks for this PR.
Do you think you could update the following tests to ensure that the config map aren't generated when one daemonset or deployment isn't enabled:
helm-charts/metricbeat/tests/metricbeat_test.py
Lines 1177 to 1194 in dd4241b
def test_disable_daemonset(): | |
config = """ | |
daemonset: | |
enabled: false | |
""" | |
r = helm_template(config) | |
assert name not in r.get("daemonset", {}) | |
def test_disable_deployment(): | |
config = """ | |
deployment: | |
enabled: false | |
""" | |
r = helm_template(config) | |
assert name + "-metrics" not in r.get("deployment", {}) |
If for daemonset/deployment is not enabled, dont generate useless config YAML. [metricbeat] Add tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM⛴
jenkins test this please |
If for daemonset/deployment is not enabled, dont generate useless config YAML.
If for daemonset/deployment is not enabled, dont generate useless config YAML.
If for daemonset/deployment is not enabled, dont generate useless config YAML.
backported to |
If for daemonset/deployment is not enabled, dont generate useless config YAML.
${CHART}/tests/*.py
${CHART}/examples/*/test/goss.yaml