-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for Kafka output UI for Fleet managed agents #336
Conversation
This pull request does not have a backport label. Could you fix it @kilfoyle? 🙏
|
This pull request is now in conflict. Could you fix it @kilfoyle? 🙏
|
Removed the Channel Buffer Size parameter per elastic/kibana#162875 (comment) |
Hi @kilfoyle, I think it would be good to involve @szwarckonrad in this review as he actually worked on implementing the feature so he has more in-depth knowledge of the kafka options. I'll request his review as well. |
@faec Would you mind taking a look at these descriptions of the Kafka authentication settings, just to be sure I'm on the right track? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, haven't checked the Kafka settings in detail.
It would be nice to add some screenshots about where to find the Add output
button in Fleet settings
, and how the Add new output
flyout looks like. Though the instructions are there as text, so that's fine too.
docs/en/ingest-management/fleet/fleet-settings-output-kafka.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/fleet/fleet-settings-output-kafka.asciidoc
Outdated
Show resolved
Hide resolved
Looks great! I've added a few comments - just some suggestions on how we might enhance clarity. Another consideration arose today - whenever an user selects the Kafka output type, we will display the warning detailed in this ticket and depicted in this pull request. |
Thanks for the excellent feedback! @szwarckonrad I adopted all your suggestions (via f0e68b3) and added a tip at the top of the docs page @juliaElastic Good idea to add a graphic. I've added one to help people find the |
This adds docs for the new Kafka output settings UI
Elasticsearch
,Logstash
, andKafka
output settings sections into separate sub-pages.Preview site
Closes: #68