Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an introduction to FLEET_SERVER_ELASTICSEARCH_CA_TRUSTED_FINGERPRINT #409

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Add an introduction to FLEET_SERVER_ELASTICSEARCH_CA_TRUSTED_FINGERPRINT #409

merged 2 commits into from
Aug 14, 2023

Conversation

linghengqian
Copy link
Contributor

@cla-checker-service
Copy link

cla-checker-service bot commented Aug 11, 2023

💚 CLA has been signed

@mergify
Copy link
Contributor

mergify bot commented Aug 11, 2023

This pull request does not have a backport label. Could you fix it @linghengqian? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@kilfoyle kilfoyle self-assigned this Aug 14, 2023
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linghengqian
Thanks very much for adding this!
I hope you don't mind that I pushed a commit directly to your branch so that the changes will appear in the docs, and I also added very small edits to use variables for the product names. Here's how it appears when I run a test build:
Screenshot 2023-08-14 at 10 53 22 AM

LGTM! 👍

@kilfoyle
Copy link
Contributor

I added a backport-8.9 label so that this will go into the current docs.

@kilfoyle kilfoyle merged commit b4717f8 into elastic:main Aug 14, 2023
mergify bot pushed a commit that referenced this pull request Aug 14, 2023
…RINT` (#409)

* Add an introduction to `FLEET_SERVER_ELASTICSEARCH_CA_TRUSTED_FINGERPRINT`

* Add include statement plus small edits

---------

Co-authored-by: David Kilfoyle <david.kilfoyle@elastic.co>
(cherry picked from commit b4717f8)
@linghengqian linghengqian deleted the add-fleet-server-env branch August 14, 2023 15:22
kilfoyle pushed a commit that referenced this pull request Aug 14, 2023
…RINT` (#409) (#410)

* Add an introduction to `FLEET_SERVER_ELASTICSEARCH_CA_TRUSTED_FINGERPRINT`

* Add include statement plus small edits

---------

Co-authored-by: David Kilfoyle <david.kilfoyle@elastic.co>
(cherry picked from commit b4717f8)

Co-authored-by: Ling Hengqian <linghengqian@outlook.com>
@jgaines911
Copy link

Is this supposed to be a base64 encode of the sha-256 fingerprint? I would assume not since it does not explicitly say it, but I have seen other elastic documentation calling for the base64 of the ca trusted fingerprint.

@linghengqian
Copy link
Contributor Author

Is this supposed to be a base64 encode of the sha-256 fingerprint? I would assume not since it does not explicitly say it, but I have seen other elastic documentation calling for the base64 of the ca trusted fingerprint.

  • @jgaines911 I remember that this configuration item has existed in the corresponding golang file since Elastic Stack 8.0.x. I just followed its description in other documents to synchronize the instructions here.

  • Anyway, maybe you could try submitting another documentation PR?

@jgaines911
Copy link

Is this supposed to be a base64 encode of the sha-256 fingerprint? I would assume not since it does not explicitly say it, but I have seen other elastic documentation calling for the base64 of the ca trusted fingerprint.

  • @jgaines911 I remember that this configuration item has existed in the corresponding golang file since Elastic Stack 8.0.x. I just followed its description in other documents to synchronize the instructions here.
  • Anyway, maybe you could try submitting another documentation PR?

Understood @linghengqian , thank you! I hope to have a call with an elastic engineer next week, so I will definitely ask then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants