Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that remote ES service token can be stored as a secret #762

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Document that remote ES service token can be stored as a secret #762

merged 2 commits into from
Dec 14, 2023

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Dec 13, 2023 •
edited
Loading

This follows #696 to add a setting that I missed in the first PR.

That first PR added notes that the following output settings can be stored as secrets:

  • Kafka output password
  • Kafka output SSL key
  • Logstash output SSL key

This PR adds a similar note for the Remote Elasticsearch service token:

Rel: #692

See Preview page

screen

@kilfoyle kilfoyle requested a review from a team as a code owner December 13, 2023 20:39
@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@kilfoyle kilfoyle mentioned this pull request Dec 13, 2023
Merged
jillguyonnet
jillguyonnet approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@jillguyonnet jillguyonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

karenzone
karenzone approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kilfoyle kilfoyle merged commit 1fffeff into elastic:main Dec 14, 2023
4 checks passed
mergify bot pushed a commit that referenced this pull request Dec 14, 2023
@kilfoyle @mergify
Document that remote ES service token can be stored as a secret (#762)
640b2ad 
* Document that remote ES service token can be stored as a secret

* fixup

(cherry picked from commit 1fffeff)
@mergify mergify bot mentioned this pull request Dec 14, 2023
Merged
kilfoyle added a commit that referenced this pull request Dec 14, 2023
@mergify @kilfoyle
Document that remote ES service token can be stored as a secret (#762) (
2cc12bb 
#768)

* Document that remote ES service token can be stored as a secret

* fixup

(cherry picked from commit 1fffeff)

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
@kilfoyle kilfoyle mentioned this pull request Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenzone karenzone karenzone approved these changes

@jillguyonnet jillguyonnet jillguyonnet approved these changes

Assignees
No one assigned
Labels
backport-8.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kilfoyle @jillguyonnet @karenzone