Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

presets only apply to 8.12 and above agents #774

Merged
merged 2 commits into from
Dec 19, 2023
Merged

presets only apply to 8.12 and above agents #774

merged 2 commits into from
Dec 19, 2023

Conversation

nimarezainia
Copy link
Contributor

presets only apply to 8.12 and above agents.

@kilfoyle I am not sure if the version can be referenced this way or needs a variable.

@nimarezainia
presets only apply to 8.12 and aobve agents
6a5230c 
presets only apply to 8.12 and aobve agents
@nimarezainia nimarezainia requested a review from a team as a code owner December 18, 2023 03:57
@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2023

This pull request does not have a backport label. Could you fix it @nimarezainia? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot removed the backport-skip label Dec 19, 2023
karenzone
karenzone reviewed Dec 19, 2023
View reviewed changes
docs/en/ingest-management/fleet/fleet-settings-output-elasticsearch.asciidoc
@@ -185,6 +185,8 @@ For descriptions of each setting, refer to <<es-output-settings-yaml-config,Adva
As mentioned, the `custom` preset allows you to input your own set of parameters for a finer tuning of performance. The following table
is a summary of a few data points and how the resulting EPS compares to the `Balanced` setting mentioned above.

These presets apply only to agents on version 8.12.0 or later.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimarezainia: Typically we use our built-in docs versioning to communicate this information. Meaning that this content would be only in the 8.12 branch and later branches.
As this could be confusing to users on pre-8.12 versions who might be looking at current docs, I'm inclined to add this.

karenzone
karenzone approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karenzone karenzone requested review from a team and removed request for kilfoyle December 19, 2023 18:06
karenzone
karenzone approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-trying approval on behalf on platform-docs

@karenzone karenzone requested a review from a team December 19, 2023 18:35
amyjtechwriter
amyjtechwriter approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@amyjtechwriter amyjtechwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - re-trying approval from platform-docs

@karenzone karenzone merged commit f605823 into main Dec 19, 2023
4 checks passed
@karenzone karenzone deleted the nimarezainia-patch-8 branch December 19, 2023 18:39
@karenzone
Copy link
Contributor

50367/8

mergify bot pushed a commit that referenced this pull request Dec 19, 2023
@nimarezainia @mergify
presets only apply to 8.12 and above agents (#774)
cf74c2a 
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
(cherry picked from commit f605823)
@mergify mergify bot mentioned this pull request Dec 19, 2023
Merged
karenzone pushed a commit that referenced this pull request Dec 19, 2023
@mergify @nimarezainia
presets only apply to 8.12 and above agents (#774) (#781)
4c6b328 
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
(cherry picked from commit f605823)

Co-authored-by: nima <nima.rezainia@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyjtechwriter amyjtechwriter amyjtechwriter approved these changes

@karenzone karenzone karenzone approved these changes

Assignees
No one assigned
Labels
backport-8.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nimarezainia @karenzone @amyjtechwriter