Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information about elastic agent diagnostics flow #789

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Add information about elastic agent diagnostics flow #789

merged 2 commits into from
Jan 4, 2024

Conversation

philippkahr
Copy link
Contributor

@philippkahr philippkahr commented Jan 4, 2024 •
edited
Loading

I think we should mention how the data is flowing. Otherwise it can be confusing. How will be the elastic agent diagnostics be retrieved, if no Elasticsearch output is defined because logstash is used.

Maybe we can add a simplified version of the flow chart: https://user-images.githubusercontent.com/6766512/190254026-75cc900f-08c6-48c7-8789-56bd8304d933.png from https://github.com/elastic/ingest-dev/issues/1224

thanks to @ckauf for digging the things up.

@philippkahr philippkahr requested a review from a team as a code owner January 4, 2024 12:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@mergify Mergify
Copy link

mergify bot commented Jan 4, 2024

This pull request does not have a backport label. Could you fix it @philippkahr? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Jan 4, 2024
kilfoyle
kilfoyle previously approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this @philippkahr
I added just one suggestion for the text.

Also, if we need a flow chart I would suggest creating a separate issue for that as it's considerable effort to design and add complex graphics into the docs. Personally, I'd suggest that the troubleshooting information is clear as is.

@philippkahr @kilfoyle
Update troubleshooting.asciidoc
def49aa 
Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
kilfoyle
kilfoyle approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kilfoyle
Copy link
Contributor

kilfoyle commented Jan 4, 2024

I'll merge this and make sure the backports go through.

@kilfoyle kilfoyle merged commit 858e99f into elastic:main Jan 4, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Jan 4, 2024
@philippkahr @mergify
Add information about elastic agent diagnostics flow (#789)
5c5bb23 
* Add information about diagnostics flow

* Update troubleshooting.asciidoc

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit 858e99f)
@mergify mergify bot mentioned this pull request Jan 4, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jan 4, 2024
@philippkahr @mergify
Add information about elastic agent diagnostics flow (#789)
02476cd 
* Add information about diagnostics flow

* Update troubleshooting.asciidoc

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit 858e99f)
@mergify mergify bot mentioned this pull request Jan 4, 2024
Merged
kilfoyle pushed a commit that referenced this pull request Jan 4, 2024
@mergify @philippkahr
Add information about elastic agent diagnostics flow (#789) (#792)
5f9e9ba 
* Add information about diagnostics flow

* Update troubleshooting.asciidoc

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit 858e99f)

Co-authored-by: Philipp Kahr <philipp.kahr@elastic.co>
kilfoyle pushed a commit that referenced this pull request Jan 4, 2024
@mergify @philippkahr
Add information about elastic agent diagnostics flow (#789) (#791)
7edc1a7 
* Add information about diagnostics flow

* Update troubleshooting.asciidoc

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit 858e99f)

Co-authored-by: Philipp Kahr <philipp.kahr@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilfoyle kilfoyle kilfoyle approved these changes

Assignees
No one assigned
Labels
backport-8.11 backport-8.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippkahr @kilfoyle