Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[netflow] add workers option #11025

Merged

Conversation

pkoutsovasilis
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis commented Sep 6, 2024

Proposed commit message

This PR exposes the workers config option introduced in netflow filebeat input which will be available when 8.16.0 version is released

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

N/A

How to test this PR locally

elastic-package test system

Related issues

Screenshots

image

@pkoutsovasilis pkoutsovasilis added enhancement New feature or request Integration:netflow NetFlow Records Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Sep 6, 2024
@pkoutsovasilis pkoutsovasilis self-assigned this Sep 6, 2024
@pkoutsovasilis pkoutsovasilis force-pushed the pkoutsovasilis/netflow_workers branch from 5942034 to 63b8bfa Compare September 6, 2024 09:31
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@pkoutsovasilis
Copy link
Contributor Author

@andrewkroh given that this field is only available from 8.16.0 and onwards, I am not sure if should merge this PR before we get closer to the release date of the former. It would be way easier if we could define the minimum stack version for fields in the manifest and in the policy handlebars file of each datastream but this is not available (maybe it is worth investigating support for such a feature?!). So any ideas how to proceed here?

@botelastic
Copy link

botelastic bot commented Oct 19, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Oct 19, 2024
@botelastic botelastic bot removed the Stalled label Nov 7, 2024
@andrewkroh andrewkroh marked this pull request as ready for review November 7, 2024 19:21
@andrewkroh andrewkroh requested a review from a team as a code owner November 7, 2024 19:21
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

The feature will only take effect if you have upgraded
to elastic agent 8.16.0. Otherwise the setting is ignored.
@andrewkroh
Copy link
Member

Setting this as ready for review because we are approaching the 8.16.0 release.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @jrmolin @pkoutsovasilis

@andrewkroh andrewkroh merged commit 69fd5a2 into elastic:main Nov 19, 2024
5 checks passed
@elastic-vault-github-plugin-prod

Package netflow - 2.20.0 containing this change is available at https://epr.elastic.co/package/netflow/2.20.0/

flexitrev pushed a commit that referenced this pull request Jan 23, 2025
This exposes the `workers` config option introduced in netflow 
filebeat input and is available in `>=8.16.0`.

---------

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:netflow NetFlow Records Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Filebeat] Auto-scale number of netflow decoder workers
5 participants