-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qualys_vmdr.knowledge_base: Handle *_LIST fields containing multiple values. #11877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
kcreddy
added
bugfix
Pull request that fixes a bug issue
Integration:qualys_vmdr
Qualys VMDR
Team:Security-Service Integrations
Security Service Integrations Team [elastic/security-service-integrations]
labels
Nov 26, 2024
kcreddy
changed the title
qualys_vmdr.knowledge_base: Handle *_LIST fields containing multiple elements.
qualys_vmdr.knowledge_base: Handle *_LIST fields containing multiple values.
Nov 26, 2024
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
cc @kcreddy |
Quality Gate failedFailed conditions |
efd6
reviewed
Nov 26, 2024
efd6
approved these changes
Nov 27, 2024
Package qualys_vmdr - 5.2.2 containing this change is available at https://epr.elastic.co/package/qualys_vmdr/5.2.2/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
Pull request that fixes a bug issue
Integration:qualys_vmdr
Qualys VMDR
Team:Security-Service Integrations
Security Service Integrations Team [elastic/security-service-integrations]
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Current ingest pipeline only handles
*_LIST
response elements such asSOFTWARE_LIST
as a single value.When
*_LIST
is an array with objects, the respective fields remain unpopulated.This PR:
*_LIST
fields are an array by extracting them into relevant fields inside ingest pipeline.diagnosis
andsolution
custom fields tomatch_only_text
to avoid errors in system test.match_only_text
correctly defines these fields instead of existingkeyword
type.Note
Following error occurs when mappings for
diagnosis
andsolution
arekeyword
:test case failed: found ignored fields in data stream: found ignored fields in data stream logs-qualys_vmdr.knowledge_base-84257: [qualys_vmdr.knowledge_base.diagnosis.value qualys_vmdr.knowledge_base.solution.value]. Affected documents:....
Checklist
changelog.yml
file.How to test this PR locally
Run pipeline tests (added new log line):
Command:
$ eval "$(elastic-package stack shellinit)" && elastic-package test pipeline --generate -v --data-streams=knowledge_base
Result:
Run system tests with config file option (added new config with single, multiple element responses)
Command:
cd packages/qualys_vmdr && elastic-package test system --generate -v --setup --config-file ./data_stream/knowledge_base/_dev/test/system/test-0_valid-mixed-list-config.yml
Result:
Teardown system test changes:
Related issues