Skip to content

Remove unused pipelines {apache, aws.cloudtrail, nginx, zeek} #16133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove unused pipelines {apache, aws.cloudtrail, nginx, zeek} #16133

wants to merge 3 commits into from

Conversation

@vinit-chauhan
Copy link
Contributor

@vinit-chauhan vinit-chauhan commented Nov 26, 2025

Proposed commit message

In the PR elastic/integrations#14995 unused httpjson file for third-party ingest pipelines was removed. However, the pipeline and the its reference in default pipeline still existed.

This PR removes those references. Including,

  • The pipeline yaml file ( third-party.yml )
  • Redirection to third-party pipeline in default pipeline.
  • Pipeline tests associated with it.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@vinit-chauhan vinit-chauhan requested a review from a team as a code owner November 26, 2025 19:17
@vinit-chauhan vinit-chauhan added the Integration:apache Apache HTTP Server label Nov 26, 2025
@vinit-chauhan vinit-chauhan requested review from a team as code owners November 26, 2025 19:17
@vinit-chauhan vinit-chauhan added Integration:aws AWS Integration:zeek Zeek Integration:nginx Nginx Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] labels Nov 26, 2025
@elasticmachine
Copy link

elasticmachine commented Nov 26, 2025

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link

elasticmachine commented Nov 26, 2025

Pinging @elastic/integration-experience (Team:Integration-Experience)

efd6
efd6 reviewed Nov 26, 2025
View reviewed changes
packages/aws/changelog.yml
Copy link
Contributor

@efd6 efd6 Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a removal of functionality that we do not know that people are not using (apologies for the mass of negatives). I'm not sure that this is safe to do, but if it is, it would be a breaking change.

Copy link
Contributor Author

@vinit-chauhan vinit-chauhan Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ingestion path for third-party Rest APIs has already been remove quite a while ago in #11767. However, the reference to the ingest pipeline still exists.
I'm note sure about the telemetry around that.

@qcorporation - do you have any telemetry just to make sure?

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 26, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 26, 2025

💚 Build Succeeded

@vinit-chauhan vinit-chauhan deleted the remove-unused-pipelines branch November 27, 2025 16:03
@vinit-chauhan vinit-chauhan restored the remove-unused-pipelines branch November 27, 2025 16:03
@vinit-chauhan vinit-chauhan reopened this Nov 27, 2025
mjwolf
mjwolf approved these changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@mjwolf mjwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I only reviewed the files in zeek, which is the only integration here owned by integration-experience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 left review comments

@mjwolf mjwolf mjwolf approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Integration:apache Apache HTTP Server Integration:aws AWS Integration:nginx Nginx Integration:zeek Zeek Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider Removing third-party pipeline invokation and definition from Nginx, Apache, AWS CloudTrail, Zeek integration

4 participants

@vinit-chauhan @elasticmachine @mjwolf @efd6