Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Microsoft_DHCP] New package replacing old RSA2ELK DHCP package #1793

Merged
merged 4 commits into from
Oct 5, 2021

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Oct 5, 2021

What does this PR do?

This package is a rewrite of the Microsoft DHCP package, from RSA2ELK to ingest pipeline

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Oct 5, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-05T12:23:33.777+0000

  • Duration: 13 min 48 sec

  • Commit: 5c2912c

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes

packages/microsoft_dhcp/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/microsoft_dhcp/changelog.yml Outdated Show resolved Hide resolved
packages/microsoft_dhcp/manifest.yml Outdated Show resolved Hide resolved
@P1llus P1llus merged commit ea959b4 into elastic:master Oct 5, 2021
v1v added a commit to v1v/integrations that referenced this pull request Oct 6, 2021
…thub.com:v1v/integrations into feature/refactor-to-support-windows-integrations

* 'feature/refactor-to-support-windows-integrations' of github.com:v1v/integrations: (200 commits)
  [CI] Draft for windows system tests
  [journald] Create custom journald input package (elastic#1739)
  [Microsoft_DHCP] New package replacing old RSA2ELK DHCP package (elastic#1793)
  Fix contains check for forwarded tag (elastic#1861)
  [google_workspace] Fix contains check for forwarded tag (elastic#1819)
  Fix contains check for forwarded tag (elastic#1805)
  Fix contains check for forwarded tag (elastic#1815)
  Fix contains check for forwarded tag (elastic#1816)
  Fix contains check for forwarded tag (elastic#1817)
  Fix contains check for forwarded tag (elastic#1818)
  Fix contains check for forwarded tag (elastic#1820)
  Fix contains check for forwarded tag (elastic#1821)
  Fix contains check for forwarded tag (elastic#1822)
  Fix contains check for forwarded tag (elastic#1823)
  Fix contains check for forwarded tag (elastic#1824)
  Fix contains check for forwarded tag (elastic#1825)
  Fix contains check for forwarded tag (elastic#1826)
  Fix contains check for forwarded tag (elastic#1827)
  Fix contains check for forwarded tag (elastic#1828)
  Fix contains check for forwarded tag (elastic#1829)
  ...
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
…tic#1793)

* stashing changes

* format

* update changelog

* Update readme, update system tests, changes version to beta instead of ga
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants