-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCP] Add GCP Metrics Data streams #2066
Conversation
❕ Build Aborted
Expand to view the summary
Build stats
Steps errors🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
/test |
Hello @legoguy1000, I spent some time on this PR but the changes is very big and is difficult to review. Moreover I would like to add tests alongside all these changes, but this proves difficult. As I really value this contribution and I would like to move it forward, here is my proposal: I created a new branch called What do you think? From your side the only additional effort would be to split this PR, as then I would be able add the missing pieces as needed. Thank you! |
Do you want me to make each log/metricset its own policy template so they can show up individually like AWS or like I had it and just group Logs and Metrics? |
@legoguy1000 As in the AWS integration I expect each data stream will require it's own policy, but I'll check internally. In any case as we are targetting a dedicated branch I can help performing these changes after merge :) |
What does this PR do?
Migrates GCP Metricsets to GCP package
Checklist
changelog.yml
file.manifest.yml
file to point to the latest Elastic stack release (e.g.^7.13.0
).Author's Checklist
How to test this PR locally
Related issues
Screenshots