Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCP] Add GCP Metrics Data streams #2066

Closed
wants to merge 8 commits into from

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Oct 29, 2021

What does this PR do?

Migrates GCP Metricsets to GCP package

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Oct 29, 2021

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Reason: The PR is not allowed to run in the CI yet

  • Start Time: 2021-11-03T12:06:34.828+0000

  • Duration: 3 min 38 sec

  • Commit: a8e9959

Steps errors 1

Expand to view the steps failures

Google Storage Download
  • Took 0 min 0 sec . View more details here

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@legoguy1000 legoguy1000 marked this pull request as ready for review October 30, 2021 18:04
@legoguy1000 legoguy1000 changed the title #490 Add GCP Metricsets [GCP] Add GCP Metricsets Oct 30, 2021
@legoguy1000 legoguy1000 changed the title [GCP] Add GCP Metricsets [GCP] Add GCP Metrics Data streams Oct 30, 2021
packages/gcp/_dev/build/docs/metrics.md Outdated Show resolved Hide resolved
packages/gcp/_dev/build/docs/logs.md Outdated Show resolved Hide resolved
@endorama
Copy link
Member

endorama commented Nov 3, 2021

/test

@endorama
Copy link
Member

endorama commented Nov 8, 2021

Hello @legoguy1000, I spent some time on this PR but the changes is very big and is difficult to review. Moreover I would like to add tests alongside all these changes, but this proves difficult.

As I really value this contribution and I would like to move it forward, here is my proposal: I created a new branch called gcp-metrics. May you to split this PR into multiple ones (one for each datastream/metricset) and target gcp-metrics as base branch?
Doing that would allow better review and being able to merge and add tests in smaller batches, which in the end will speed up inclusion.

What do you think? From your side the only additional effort would be to split this PR, as then I would be able add the missing pieces as needed.

Thank you!

@legoguy1000 legoguy1000 closed this Nov 8, 2021
@legoguy1000
Copy link
Contributor Author

Do you want me to make each log/metricset its own policy template so they can show up individually like AWS or like I had it and just group Logs and Metrics?

@legoguy1000 legoguy1000 mentioned this pull request Nov 8, 2021
4 tasks
@endorama
Copy link
Member

@legoguy1000 As in the AWS integration I expect each data stream will require it's own policy, but I'll check internally. In any case as we are targetting a dedicated branch I can help performing these changes after merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate some Metricbeat modules to GCP package
3 participants