Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace IPs in pipeline tests with the allowed ones #2327

Merged
merged 4 commits into from
Dec 13, 2021
Merged

Replace IPs in pipeline tests with the allowed ones #2327

merged 4 commits into from
Dec 13, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Dec 9, 2021

What does this PR do?

Replace IPs in pipeline tests with ones in the allowed list. This way we ensure GeiIP is supported for all of them when testing against 8.0.0 stack.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Relates to elastic/elastic-package#605

@marc-gr marc-gr added enhancement New feature or request Team:Integrations Label for the Integrations team Team:Security-External Integrations labels Dec 9, 2021
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@kaiyan-sheng kaiyan-sheng mentioned this pull request Dec 9, 2021
Merged
4 tasks
@elasticmachine
Copy link

elasticmachine commented Dec 10, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-13T08:42:27.672+0000

  • Duration: 69 min 45 sec

  • Commit: e1a8168

Test stats 🧪

Test Results
Failed 0
Passed 2203
Skipped 2
Total 2205

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

mtojek
mtojek approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to release the new elastic-package to check if all addresses are up-to-date.

@marc-gr marc-gr merged commit 5429e34 into elastic:master Dec 13, 2021
@marc-gr marc-gr deleted the change-test-ips branch December 13, 2021 09:52
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@marc-gr
Replace IPs in pipeline tests with the allowed ones (elastic#2327)
76d1c29 
* Replace IPs in pipeline tests with the allowed ones

* Generate test files

* Add PR number to changelogs
@andrewkroh andrewkroh mentioned this pull request May 2, 2022
Merged
@andrewkroh andrewkroh mentioned this pull request May 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

@mtojek mtojek mtojek approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marc-gr @elasticmachine @mtojek @efd6