Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Checkpoint] Fix multiple field conflicts #2895

Merged
merged 2 commits into from
Mar 28, 2022
Merged

[Checkpoint] Fix multiple field conflicts #2895

merged 2 commits into from
Mar 28, 2022

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Fix field mapping conflicts for checkpoint.icmp_type, checkpoint.icmp_code & checkpoint.email_recipients_num

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@legoguy1000 legoguy1000 requested a review from a team as a code owner March 26, 2022 19:00
@elasticmachine
Copy link

elasticmachine commented Mar 26, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-28T00:29:22.038+0000

  • Duration: 14 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Mar 28, 2022

/test

@andrewkroh andrewkroh added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:checkpoint Check Point labels Mar 28, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh merged commit 87afef6 into elastic:main Mar 28, 2022
@legoguy1000 legoguy1000 deleted the 2873-checkpoint-field-conflict branch March 28, 2022 21:12
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@legoguy1000
[Checkpoint] Fix multiple field conflicts (elastic#2895)
3793f0a 
Fix field mapping conflicts for checkpoint.icmp_type, checkpoint.icmp_code & checkpoint.email_recipients_num.
This was referenced Mar 31, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
bug Something isn't working, use only for issues Integration:checkpoint Check Point
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[checkpoint] Conficting field definitions with CEF
4 participants
@legoguy1000 @elasticmachine @efd6 @andrewkroh