Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/elastic/elastic-package from 0.43.0 to 0.44.0 #2916

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 30, 2022

Bumps github.com/elastic/elastic-package from 0.43.0 to 0.44.0.

Release notes

Sourced from github.com/elastic/elastic-package's releases.

v0.44.0

Changelog

  • 48457916 Import aditional indexing settings on external fields (#752)
  • 9c95e81f Update add-to-ecosystem-project.yml (#763)
  • 88075ee1 Re-enable AWS tests (#758)
  • 34949ba1 Update add-to-ecosystem-project.yml (#761)
  • 2cc8d9ff Fix: update PR reviewers (#757)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/elastic/elastic-package](https://github.com/elastic/elastic-package) from 0.43.0 to 0.44.0.
- [Release notes](https://github.com/elastic/elastic-package/releases)
- [Changelog](https://github.com/elastic/elastic-package/blob/main/.goreleaser.yml)
- [Commits](elastic/elastic-package@v0.43.0...v0.44.0)

---
updated-dependencies:
- dependency-name: github.com/elastic/elastic-package
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner March 30, 2022 08:56
@dependabot dependabot bot requested review from a team as code owners March 30, 2022 09:00
@elasticmachine
Copy link

elasticmachine commented Mar 30, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-31T10:35:11.658+0000

  • Duration: 86 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 4412
Skipped 7
Total 4419

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@jsoriano
Copy link
Member

/test

@dependabot dependabot bot requested a review from a team as a code owner March 30, 2022 17:17
| ecs.version | ECS version this event conforms to. `ecs.version` is a required field and must exist in all events. When querying across multiple indices -- which may conform to slightly different ECS versions -- this field lets integrations adjust to the schema version of the events. | keyword |
| error.message | Error message. | match_only_text |
| event.action | The action captured by the event. This describes the information in the event. It is more specific than `event.category`. Examples are `group-add`, `process-started`, `file-created`. The value is normally defined by the implementer. | keyword |
| event.category | This is one of four ECS Categorization Fields, and indicates the second level in the ECS category hierarchy. `event.category` represents the "big buckets" of ECS categories. For example, filtering on `event.category:process` yields all events relating to process activity. This field is closely related to `event.type`, which is used as a subcategory. This field is an array. This will allow proper categorization of some events that fall in multiple categories. | keyword |
| event.code | Identification code for this event, if one exists. Some event sources use event codes to identify messages unambiguously, regardless of message language or wording adjustments over time. An example of this is the Windows Event ID. | keyword |
| event.dataset | Event dataset | constant_keyword |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... something may be fishy here: constant_keyword -> keyword, not sure if this is what we want to achieve?

Copy link
Member

@jsoriano jsoriano Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm, this field is defined in two places, here and here. But no idea why it is starting to use the ECS one now. 🤔

It is actually defined as keyword in ECS. Should I remove this from the base-fields.yml?

And we should probably add some check to avoid duplicated fields.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am removing the duplicated ECS field by now in ec7f030, so this goes back to its previous format.

@elastic/security-external-integrations please review this part (https://github.com/elastic/integrations/pull/2916/files#diff-ffb7ef2a530f578dd42fcac9c93d03032982b15c37d5fd142fdc61406f5b9cdeL39).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding validation for duplicated fields in elastic/package-spec#309.

@mtojek
Copy link
Contributor

mtojek commented Mar 31, 2022

It looks like a file conflict bumped up in the meantime.

@mtojek mtojek self-requested a review March 31, 2022 10:14
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to ship it and use "god mode" to merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants