Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable kubernetes time series #3119

Closed
wants to merge 11 commits into from

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Apr 19, 2022

Enable time series mode in kubernetes data streams.

This change requires Elasticsearch 8.4.

Fixed also some typos and duplicated fields.

@jsoriano jsoriano self-assigned this Apr 19, 2022
@elasticmachine
Copy link

elasticmachine commented Apr 19, 2022

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-15T16:36:07.121+0000

  • Duration: 16 min 57 sec

Steps errors 3

Expand to view the steps failures

Test integration: kubernetes
  • Took 1 min 17 sec . View more details here
  • Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage
Delete kind cluster
  • Took 0 min 13 sec . View more details here
  • Description: kind delete cluster
Google Storage Download
  • Took 0 min 0 sec . View more details here

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@jsoriano jsoriano marked this pull request as ready for review May 11, 2022 10:15
@jsoriano jsoriano requested a review from a team as a code owner May 11, 2022 10:15
@ChrsMark ChrsMark self-requested a review May 11, 2022 10:30
@elasticmachine
Copy link

elasticmachine commented May 11, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.589
Classes 100.0% (0/0) 💚 3.589
Methods 100.0% (26/26) 💚 11.711
Lines 100.0% (0/0) 💚 10.983
Conditionals 100.0% (0/0) 💚

@@ -10,7 +10,7 @@ categories:
- kubernetes
release: ga
conditions:
kibana.version: "^8.2.0"
kibana.version: "^8.3.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that we need this in order to add index.mode: time_series in the indexes?
My only concern about this is that once again we move compatibility forward making it hard for bugfixes to land in the future. Not blocking though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was the concern I had about the approach of using the manifest elasticsearch settings.

@jsoriano jsoriano marked this pull request as draft May 24, 2022 09:37
@jsoriano
Copy link
Member Author

jsoriano commented Jun 21, 2022

Approach in this PR is not valid. It installs the index.mode setting in the @package component template, but in order to leverage elastic/elasticsearch#86790, it needs to be installed in the composable template. Started elastic/package-spec#357 to add a new setting in the spec for this.

@jsoriano jsoriano closed this Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants