Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CheckPoint package with RFC 5424 parsing fix #351

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Update CheckPoint package with RFC 5424 parsing fix #351

merged 2 commits into from
Oct 29, 2020

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Oct 28, 2020

What does this PR do?

Sync the change from elastic/beats#21854 to use the UDP input instead of syslog input
to allow for RFC 5424 syslog parsing.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

@andrewkroh andrewkroh added the enhancement New feature or request label Oct 28, 2020
@elasticmachine
Copy link

elasticmachine commented Oct 28, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #351 updated]

  • Start Time: 2020-10-28T23:50:17.539+0000

  • Duration: 16 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

Sync the change from elastic/beats#21854 to use the UDP input instead of syslog input
to allow for RFC 5424 syslog parsing.
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@@ -36,9 +36,9 @@ policy_templates:
type: text
title: Paths
multi: true
required: false
required: true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, quick question, based off of https://www.elastic.co/guide/en/beats/filebeat/master/filebeat-module-checkpoint.html#_firewall_fileset_settings -- it looks like this isn't necessarily required and filebeat will default to globbing on known system log directories? Just wondering why the switch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither the module nor the package specify default paths for the CheckPoint log files. Probably because there isn't a standard path due to syslog streaming being the primary delivery means.

I marked it as required to prevent the package from being installed without setting any path. If you start the logfile stream without any paths it will cause an error in filebeat since it cannot start the log input without any paths.

@andrewkroh andrewkroh merged commit d5f035d into elastic:master Oct 29, 2020
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
* Update CheckPoint package with RFC 5424 parsing fix

Sync the change from elastic/beats#21854 to use the UDP input instead of syslog input
to allow for RFC 5424 syslog parsing.

* paths is required for logfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants