Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS Fargate] Added support for DesiredStatus and KnownStatus for ECS Tasks #3835

Merged
merged 4 commits into from
Jul 26, 2022

Conversation

girodav
Copy link
Contributor

@girodav girodav commented Jul 26, 2022

What does this PR do?

This PR adds DesiredStatus and KnownStatus among the collected metrics for ECS Fargate. The values are collected at the task level, not at the container level. More info at: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-metadata-endpoint-v4.html

Related PR for beats elastic/beats#32342

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

To test the end-to-end data flow, the easiest approach involves running amazon-ecs-local-container-endpoints and elastic-agent in two Docker containers on the same network (more info available at this blog post from AWS)

Related issues

@girodav girodav requested a review from a team as a code owner July 26, 2022 09:40
@girodav girodav self-assigned this Jul 26, 2022
@girodav girodav added enhancement New feature or request Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Jul 26, 2022
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-26T09:41:09.839+0000

  • Duration: 14 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.901
Classes 100.0% (0/0) 💚 2.901
Methods 66.667% (2/3) 👎 -22.665
Lines 100.0% (0/0) 💚 9.423
Conditionals 100.0% (0/0) 💚

@girodav girodav merged commit efc513f into elastic:main Jul 26, 2022
@girodav girodav deleted the add_desired_known_status branch July 26, 2022 10:07
@zmoog zmoog added the Integration:aws AWS label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metricbeat] [AWS Fargate] Include 'DesiredStatus' and 'KnownStatus' fields with module/agent integration
3 participants