Skip to content

[AWS] Fix EC2 dashboard #4057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 25, 2022
Merged

[AWS] Fix EC2 dashboard #4057

merged 4 commits into from
Aug 25, 2022

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Aug 23, 2022

What does this PR do?

This PR is to fix EC2 OOTB dashboard:

Screen Shot 2022-08-23 at 4 09 30 PM

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@kaiyan-sheng kaiyan-sheng requested review from a team as code owners August 23, 2022 22:19
@kaiyan-sheng kaiyan-sheng self-assigned this Aug 23, 2022
@kaiyan-sheng kaiyan-sheng added Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Aug 23, 2022
@elasticmachine
Copy link

elasticmachine commented Aug 23, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-25T14:15:47.304+0000

  • Duration: 39 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 162
Skipped 2
Total 164

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 23, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (13/13) 💚
Files 92.857% (13/14) 👎 -4.334
Classes 92.857% (13/14) 👎 -4.334
Methods 84.232% (203/241) 👎 -5.162
Lines 95.697% (5204/5438) 👍 4.77
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

At least some of the old field names appear to also be valid. For example, I see you changed aws.ec2.diskio.write.bytes to host.disk.write.bytes, but the old field appears to exist (no error here):

Screen Shot 2022-08-24 at 9 51 37 AM

So, I'm assuming you had other reasons for changing the fields?

@kaiyan-sheng
Copy link
Contributor Author

So, I'm assuming you had other reasons for changing the fields?

Yep we switched the fields to the new ECS fields as a part of the inventory schema initiative: elastic/beats#19757

@kaiyan-sheng kaiyan-sheng merged commit d26644c into elastic:main Aug 25, 2022
@kaiyan-sheng kaiyan-sheng deleted the ec2_dashboard branch August 25, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants