-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[salesforce] Add salesforce
package foundation along with logout_rest
data stream
#4323
[salesforce] Add salesforce
package foundation along with logout_rest
data stream
#4323
Conversation
🚀 Benchmarks reportTo see the full report comment with |
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…to package_salesforce_logout_rest
…to package_salesforce_logout_rest
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
…to package_salesforce_logout_rest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also consider changing the title of the panel as
Top 10 IP address by Logout request count
-> We have currently |
@agithomas We have followed this official documentation from Salesforce for all the fields descriptions. We have attached same link in README.md Please have a look over this once. |
Some of the suggestions are correct from Elastic's documentation perspective. If you find any suggestions conflicting, please point out. |
Yes, please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend to include a Geo Map similar to login_rest datastream to indicate the logout geo locations making use of the geo lat & lon fields
packages/salesforce/data_stream/logout_rest/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/salesforce/data_stream/logout_rest/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Package salesforce - 0.2.0 containing this change is available at https://epr.elastic.co/search?package=salesforce |
What does this PR do?
logout_rest
)Checklist
changelog.yml
file.manifest.yml
file to point to the latest Elastic stack release (e.g.^7.13.0
).How to test this PR locally