-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stack Monitoring] Remove release field, add preview1 identifier #4403
Conversation
This is based on recommendations in elastic/kibana#122973 and elastic/package-spec#225
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
gc |
10526.32 | 7692.31 | -2834.01 (-26.92%) | 💔 |
Package kibana
👍(1) 💚(0) 💔(1)
Expand to view
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
audit |
8849.56 | 6134.97 | -2714.59 (-30.67%) | 💔 |
To see the full report comment with /test benchmark fullreport
🌐 Coverage report
|
This avoids sorting behind the `release: experimental` packages. We could have ES be 2.0.0 but seemed good to align them as part of agent-based monitoring.
@crespocarlos @klacabane do either of you happen to know if this is "safe" with regards to release? I'm hoping |
I think once you bump the version a release is made, I think that's why we held off with bumping the version until we were ready with all changes. |
Thanks @miltonhultgren ! Maybe we can save this PR for last, then. I think if we just remove the |
There are currently 3 stages, a commit to the repo will publish to the snapshot stage while staging and production stages needs manual operation (documentation here https://github.com/elastic/package-storage/). Now this model will be deprecated in favor of a v2 approach that only exposes a single stage but I don't have the specifics on when this is supposed to happen @matschaffer can we bump minor or is 1.0.0 taking precedence over 1.1.0-preview1 ? |
I suspect 1.1.0-preview1 will work. I'll go with that 👍🏻 |
Updated. Given what @klacabane said I'm guessing this is okay to merge now and we'll do the manual release process once we've confirmed all the functionality is working as expected. |
Interesting. Looks like merging this caused the following PRs to get opened:
I'm inclined to go ahead with merge and "release" since the packages have been working in our tests so far, though it may be odd to have it launch ahead of 8.5.0. Either way it's probably unlikely someone would install them by accident since you have to search or click via the metricbeat "integration" card. What say you folks? Merge the above (and release) or hold? |
PRs target the snapshot stage which is equivalent to dev I think so no customers will see it unless they specifically point to that stage |
What does this PR do?
Remove release field, add preview1 identifier
This is based on recommendations in elastic/kibana#122973 and elastic/package-spec#225
Checklist
changelog.yml
file.How to test this PR locally
Note that the label will show "Beta" until elastic/kibana#122973 is addressed.
Related issues
Closes #4107
Screenshots
Filebeat/metricbeat tutorials on integration search
Link on metrics page to agent package
Package with new version