Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSDB Enablement for InfluxDB #5312

Merged
merged 13 commits into from
Mar 21, 2023
Merged

TSDB Enablement for InfluxDB #5312

merged 13 commits into from
Mar 21, 2023

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Feb 17, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • TSDB Enablement for InfluxDB
  • Minor dashboard fix

The change includes

  • adding new fields that are essential for dimension mapping and field mapping for the newly added field
  • tag fields that are dimensions

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

  • Download, Install, configure Influxdb
  • Download, Install, configure telegraf
  • Configure telegraf to inject data into the influxdb
  • Create tasks in influxdb to generate task related metrics
  • Confiugure the integration
  • Verify the dashboard is loaded correctly without missing data except panels reporting errors.

Related issues

elastic/elastic-package#1174

Screenshots

@agithomas agithomas requested a review from a team as a code owner February 17, 2023 07:59
@agithomas agithomas mentioned this pull request Feb 17, 2023
Closed
11 tasks
@elasticmachine
Copy link

elasticmachine commented Feb 17, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-16T10:43:13.497+0000

  • Duration: 16 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Feb 17, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 75.0% (6/8) ❕
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@lalit-satapathy
Copy link
Collaborator

Can we remove Oracle package relevant changes from this PR? This PR is only for InfluxDB changes.

@agithomas agithomas force-pushed the issue-5283-influxdb-tsdb branch 2 times, most recently from 4da1193 to a2f99fc Compare February 20, 2023 13:22
@agithomas agithomas force-pushed the issue-5283-influxdb-tsdb branch from a2f99fc to e9722ce Compare February 20, 2023 13:25
@agithomas
Copy link
Contributor Author

/test

@agithomas agithomas force-pushed the issue-5283-influxdb-tsdb branch from 45056f5 to eef3935 Compare March 8, 2023 18:49
ritalwar
ritalwar approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit 0488ad7 into elastic:main Mar 21, 2023
@elasticmachine
Copy link

Package influxdb - 0.3.0 containing this change is available at https://epr.elastic.co/search?package=influxdb

@agithomas agithomas mentioned this pull request Mar 22, 2023
Closed
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Mar 23, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritalwar ritalwar ritalwar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agithomas @elasticmachine @lalit-satapathy @ritalwar