Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] Refactor config type #5448

Merged
merged 3 commits into from
Mar 6, 2023
Merged

[Cloud Security] Refactor config type #5448

merged 3 commits into from
Mar 6, 2023

Conversation

kfirpeled
Copy link
Contributor

What does this PR do?

We've refactored the configuration schema

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Just build and run with kibana, depends on elastic/kibana#152215

Related issues

Screenshots

@kfirpeled kfirpeled added enhancement New feature or request Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture] labels Mar 6, 2023
@kfirpeled kfirpeled requested a review from a team as a code owner March 6, 2023 12:17
amirbenun
amirbenun reviewed Mar 6, 2023
View reviewed changes
packages/cloud_security_posture/data_stream/vulnerabilities/agent/stream/aws.yml.hbs Outdated
@@ -1,4 +1,5 @@
config:
v1:
type: {{posture}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work?

@elasticmachine
Copy link

elasticmachine commented Mar 6, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-06T12:30:36.408+0000

  • Duration: 14 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) 👎 -75.0
Lines 100.0% (0/0) 💚 6.54
Conditionals 100.0% (0/0) 💚

@kfirpeled kfirpeled merged commit e6b0088 into elastic:main Mar 6, 2023
@kfirpeled kfirpeled deleted the cspm/refactor_config_type branch March 6, 2023 12:45
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
@kfirpeled @agithomas
[Cloud Security] Refactor config type (elastic#5448)
7651443
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@kfirpeled @agithomas
[Cloud Security] Refactor config type (elastic#5448)
c0d1455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirbenun amirbenun amirbenun approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Team:Cloud Security Label for the Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kfirpeled @elasticmachine @amirbenun