-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS Kinesis] Add metric type to fields #5866
Conversation
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
🌐 Coverage report
|
great to see this getting started for AWS! i would argue though that some of these metrics represent discrete counts (i.e the "count" metric type). for example |
I don't think they can be counter, because they reset after some time. So if the period is 5min, they will go back to 0 after that and it will start counting again. That is why I opted for gauge because the value is not always increasing @tommyers-elastic |
ah interesting - i took the different definition of 'counter' from here.
This makes sense to me, as counter type metrics typically do reset on each collection period. I notice this is different from say, here. I will ask around to get clarity on this. |
Package aws - 1.36.4 containing this change is available at https://epr.elastic.co/search?package=aws |
What does this PR do?
Add metric type to fields of Kinesis data stream, necessary to support TSDB in the future.
Details
Checklist
changelog.yml
file.How to test this PR locally
Refer to #5864
Related issues