Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS Kinesis] Add metric type to fields #5866

Merged
merged 4 commits into from
May 22, 2023

Conversation

constanca-m
Copy link
Contributor

@constanca-m constanca-m commented Apr 12, 2023

What does this PR do?

Add metric type to fields of Kinesis data stream, necessary to support TSDB in the future.

Details

  1. Every metric is a gauge. Even though some fields are constantly increasing in some period (default 5min), the value of the field will reset as soon as this period ends.
  2. The dashboard works as before/expected.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Refer to #5864

Related issues

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m added enhancement New feature or request Integration:aws AWS labels Apr 12, 2023
@constanca-m constanca-m self-assigned this Apr 12, 2023
@constanca-m constanca-m requested a review from a team as a code owner April 12, 2023 07:51
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m mentioned this pull request Apr 12, 2023
5 tasks
@elasticmachine
Copy link

elasticmachine commented Apr 12, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-22T06:55:57.532+0000

  • Duration: 50 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 188
Skipped 4
Total 192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 12, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -6.25
Classes 93.75% (15/16) 👎 -6.25
Methods 86.131% (236/274) 👎 -10.838
Lines 85.925% (7387/8597) 👍 17.708
Conditionals 100.0% (0/0) 💚

@tommyers-elastic
Copy link
Contributor

great to see this getting started for AWS!

i would argue though that some of these metrics represent discrete counts (i.e the "count" metric type). for example PutRecords_TotalRecords.sum or PutRecords_FailedRecords. what do you think?

@constanca-m
Copy link
Contributor Author

great to see this getting started for AWS!

i would argue though that some of these metrics represent discrete counts (i.e the "count" metric type). for example PutRecords_TotalRecords.sum or PutRecords_FailedRecords. what do you think?

I don't think they can be counter, because they reset after some time. So if the period is 5min, they will go back to 0 after that and it will start counting again. That is why I opted for gauge because the value is not always increasing @tommyers-elastic

@tommyers-elastic
Copy link
Contributor

ah interesting - i took the different definition of 'counter' from here.

A number that only increases or resets to 0 (zero). For example, a count of errors or completed tasks.

This makes sense to me, as counter type metrics typically do reset on each collection period.

I notice this is different from say, here. I will ask around to get clarity on this.

@constanca-m constanca-m merged commit 41f5983 into elastic:main May 22, 2023
@constanca-m constanca-m deleted the tsdb-kinesis branch May 22, 2023 07:48
@elasticmachine
Copy link

Package aws - 1.36.4 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:aws AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants