-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus Input Package #6170
Prometheus Input Package #6170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments. Otherwise, everything else LGTM.
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Package prometheus_input - 0.0.1 containing this change is available at https://epr.elastic.co/search?package=prometheus_input |
Glad to see this landed. Few follow up questions / thoughts:
Document based routing has landed in 8.8 and I think prometheus metrics is a prime use case for it. Even though we might not have default routing in place for now, we eventually should have, for example based on a service name field or similar. (@felixbarny ). Prometheus also have some default mappings that are needed. If we do routing, the target data stream should have the same mappings (@weltenwort ). This implies that potentially we need reusable component templates loaded by input packages that then can be used also by the target data streams. @eyalkoren thinks about the naming of these. Most folks I pinged above are thinking more about logs then metrics at the moment, but I expect things to work exactly the same in the metrics use case and prometheus is a good example for many discussions we had recently. |
@ishleenk17 Too late but I realised the PR is likely not the right place for all of the discussions above. Where should we take it? |
Lets track and discuss it as part of the enhancements for Prometheus Package ticket |
SGTM. Copied it over to #6320 (comment) Lets continue the conversation there. |
What does this PR do?
The Prometheus Input Package is developed in this PR.
Checklist
changelog.yml
file.How to test this PR locally
Bring up any service pushing metrics to Prometheus Endpoint. Add the Prometheus Input Integration from Kibana. Add the appropriate input configurations. The metrics should be received in Kibana.
Related issues
Screenshots