-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS] Add dimensions to S3 Storage Lens #6583
Merged
constanca-m
merged 6 commits into
elastic:main
from
constanca-m:s3-storage-lens-dimensions
Jun 28, 2023
Merged
[AWS] Add dimensions to S3 Storage Lens #6583
constanca-m
merged 6 commits into
elastic:main
from
constanca-m:s3-storage-lens-dimensions
Jun 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
/test |
packages/aws/data_stream/s3_storage_lens/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/aws/data_stream/s3_storage_lens/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/aws/data_stream/s3_storage_lens/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
💚 Build Succeeded
History
cc @constanca-m |
tetianakravchenko
approved these changes
Jun 15, 2023
🌐 Coverage report
|
constanca-m
force-pushed
the
s3-storage-lens-dimensions
branch
2 times, most recently
from
June 27, 2023 14:00
661f62d
to
0d4727a
Compare
… s3-storage-lens-dimensions # Conflicts: # packages/aws/changelog.yml # packages/aws/manifest.yml
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
kaiyan-sheng
approved these changes
Jun 27, 2023
Package aws - 1.45.4 containing this change is available at https://epr.elastic.co/search?package=aws |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Set fields as dimensions for TSDB support.
The ECS fields were chosen based on #5193 (comment).
In addition to that, a new field
dimensions_id
was created and set as dimension. It is a fingerprint ofaws.dimension.*
fields that uniquely identify a metric.Checklist
changelog.yml
file.Related issues
Relates to #6293