Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Add dimensions to S3 Storage Lens #6583

Merged
merged 6 commits into from
Jun 28, 2023

Conversation

constanca-m
Copy link
Contributor

What does this PR do?

Set fields as dimensions for TSDB support.

The ECS fields were chosen based on #5193 (comment).

In addition to that, a new field dimensions_id was created and set as dimension. It is a fingerprint of aws.dimension.* fields that uniquely identify a metric.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Relates to #6293

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m requested a review from a team as a code owner June 15, 2023 06:45
@constanca-m constanca-m self-assigned this Jun 15, 2023
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@elasticmachine
Copy link

elasticmachine commented Jun 15, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-27T14:08:34.408+0000

  • Duration: 54 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 194
Skipped 4
Total 198

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@constanca-m
Copy link
Contributor Author

/test

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @constanca-m

@elasticmachine
Copy link

elasticmachine commented Jun 15, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -6.25
Classes 93.75% (15/16) 👎 -6.25
Methods 85.714% (240/280) 👍 1.099
Lines 85.925% (7387/8597) 👎 -13.149
Conditionals 100.0% (0/0) 💚

@constanca-m constanca-m force-pushed the s3-storage-lens-dimensions branch 2 times, most recently from 661f62d to 0d4727a Compare June 27, 2023 14:00
… s3-storage-lens-dimensions

# Conflicts:
#	packages/aws/changelog.yml
#	packages/aws/manifest.yml
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m reopened this Jun 27, 2023
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m merged commit f49690d into elastic:main Jun 28, 2023
@constanca-m constanca-m deleted the s3-storage-lens-dimensions branch June 28, 2023 07:03
@elasticmachine
Copy link

Package aws - 1.45.4 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants