Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS Fargate] Remove sum of counters in dashboard #6997

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

constanca-m
Copy link
Contributor

What does this PR do?

Update DiskIO Write and Read visualizations to use last_value instead of average.

This is necessary because awsfargate.task_stats.diskio.read.bytes and awsfargate.task_stats.diskio.write.bytes, the metrics used for these visualizations, are counters. This means that the only 2 aggregations supported for them are max and last_value.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Relates to #6732.

Screenshots

Current visualizations with this change:

image

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m requested a review from a team as a code owner July 18, 2023 13:31
@constanca-m constanca-m self-assigned this Jul 18, 2023
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@elasticmachine
Copy link

elasticmachine commented Jul 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-18T13:31:33.222+0000

  • Duration: 14 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 66.667% (2/3) 👎 -33.333
Lines 100.0% (0/0) 💚 9.075
Conditionals 100.0% (0/0) 💚

@kaiyan-sheng
Copy link
Contributor

The change looks good to me. Could you update the screenshot in https://github.com/elastic/integrations/tree/main/packages/aws/img for fargate with the new visualizations?

@constanca-m
Copy link
Contributor Author

The screenshot has the new visualization @kaiyan-sheng The result is the same as the old visualization :)

@kaiyan-sheng
Copy link
Contributor

Perfect! Thanks!

@constanca-m constanca-m merged commit 59fb1b0 into elastic:main Jul 18, 2023
@constanca-m constanca-m deleted the aws-fargate-dashboard branch July 18, 2023 14:13
@elasticmachine
Copy link

Package awsfargate - 0.2.5 containing this change is available at https://epr.elastic.co/search?package=awsfargate

@andrewkroh andrewkroh added Integration:awsfargate AWS Fargate (for ECS clusters) and removed Integration:aws AWS labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:awsfargate AWS Fargate (for ECS clusters)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants