[Airflow] Revert metrics field definition to the format used before i… #7469
Conversation
…ntroducing metric_type
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Why the reverting is done? Can you link to the related issue? |
This is the issue link |
|
Package airflow - 0.3.0 containing this change is available at https://epr.elastic.co/search?package=airflow |
| @@ -435,7 +435,7 @@ | |||
| "dataType": "number", | |||
| "isBucketed": false, | |||
| "label": "Scheduler Heartbeat", | |||
| "operationType": "sum", | |||
| "operationType": "max", | |||
There was a problem hiding this comment.
@ritalwar, Was this an aggregation change to fix some issue?
There was a problem hiding this comment.
This was intended for the dashboard, as the sum aggregator isn't compatible with counters.
There was a problem hiding this comment.
avg() replaced by max() is understandable. But, sum() replaced by a max(), might change what value is shown by the dashboard panel. Can you re-assess the correctness of the dashboard value following this change?
There was a problem hiding this comment.
Please create an issue for tracking purpose, if needed.
There was a problem hiding this comment.
Agree, we can summarise the change in a top level issue (existing Airlfow TSDB issue also works)
There was a problem hiding this comment.
Created this issue.
What does this PR do?
Revert airflow metrics field definition to the format used before introducing metric_type.
This is done because of this issue.
Although, Airflow remained unaffected by this issue. However, with the fix now accessible and the necessary changes present in the elastic-package, it's good to revert to the original format.
Checklist
changelog.ymlfile.Related issues
Screenshots