Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] adding 8.10 dashboard resources #7474

Closed
wants to merge 3 commits into from

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Aug 21, 2023

What does this PR do?

Due to incompatibility between 8.9 and 8.10 dashboard resources that had some export/import issues, this PR is a followup from #7471 which adds the resources that was ignored due to the incompatilibities for 8.9 dashboards.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@P1llus P1llus added enhancement New feature or request Team:Elastic-Agent Label for the Agent team Integration:elastic_agent Elastic Agent labels Aug 21, 2023
@P1llus P1llus requested a review from a team as a code owner August 21, 2023 13:00
@elasticmachine
Copy link

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@P1llus
Copy link
Member Author

P1llus commented Aug 21, 2023

It seems that the order in which the visualizations are stored in the JSON files have changed between 8.7.1 and 8.10, so the changes looks bigger than they are, but in reality its simply changing the markdown hyperlinks.

@elasticmachine
Copy link

elasticmachine commented Aug 21, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-21T13:07:36.723+0000

  • Duration: 15 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 33.333% (25/75) 👍
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@P1llus
Copy link
Member Author

P1llus commented Aug 21, 2023

Another way we could approach it is simply modifying the saved object json files. That way we dont have to bump the version to 8.10.
We currently dont want to use dashboards exported from 8.9 due to some incompatibilities.

@P1llus
Copy link
Member Author

P1llus commented Aug 21, 2023

Closing in favour of just modifying the JSON objects rather than a re-export, allowing us to keep the 8.9 min version.

@P1llus P1llus closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:elastic_agent Elastic Agent Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links in the dashboards from elastic agent integration are not working in a multi space environment
3 participants