Adjust aws package to use input groups

[kaiyan-sheng]

What does this PR do?

This PR is to modify current aws package to use input groups in order to add icons for each service to support granular search.

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.

Related issues

• Relates Support granular search of AWS services  package-spec#122

Screenshots

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Build Cause: Branch indexing

• Start Time: 2021-06-29T22:28:59.179+0000

• Duration: 15 min 35 sec

• Commit: 1795121

Test stats 🧪

Test	Results
Failed	0
Passed	247
Skipped	0
Total	247

Trends 🧪

[sorantis]

In its current state the manifest.yml is missing the categories section both package wide and service specific. Are we planning to add these?

[kaiyan-sheng]

Update: waiting on elastic/elastic-package#282 before working on this PR again

[kaiyan-sheng]

In its current state the manifest.yml is missing the categories section both package wide and service specific. Are we planning to add these?

@sorantis Yes! I think package wide categories is already defined in manifest.yml. I will add the service specific ones in next commit! Thanks!!!

[sorantis]

yes, my bad, I looked at the diff only, which hid the existing categories.

[elasticmachine]

Pinging @elastic/integrations (Team:Integrations)

[mtojek]

@kaiyan-sheng I assume we can't merge this package yet, as other parties don't support it yet? I mean Kibana and Package Registry. I'm not sure what would be implications of merging it now :)

[kaiyan-sheng]

@kaiyan-sheng I assume we can't merge this package yet, as other parties don't support it yet? I mean Kibana and Package Registry. I'm not sure what would be implications of merging it now :)

@mtojek Yeah I just tested the AWS integration with this PR and I definitely need to work on package registry first before this PR can get merged.

[mtojek]

Maybe mark this PR as draft to prevent from accidental merge :)

[kaiyan-sheng]

@mtojek Done, back in draft mode! Thanks!

[sorantis]

The Meta elastic/package-spec#144 indicates that package registry changes have dependency on AWS package. Is it the other way around? Also, what should be done to unblock changes in Kibana?

[kaiyan-sheng]

@sorantis I'm currently working on changes in package-registry elastic/package-registry#685 to unblock Kibana work. I also pointed this draft PR to @jen-huang and hopefully combining both draft PRs together will help.

[jen-huang]

Hi all, I'm starting to assess Kibana work using the in-flight changes to AWS package in this PR along with the package registry changes. I have a question regarding the new package-level vars field introduced here:

integrations/packages/aws/manifest.yml

Lines 26 to 27 in e00cbd7

	vars:
	- name: shared_credential_file

I know we introduced support for package-level vars a little while ago in the package spec PR, but AFAIK supporting this on the Kibana side was not scoped for phase 1, so I was wondering if we can pull out that change from this PR and put those vars back at the (I think) input level?

@sorantis What do you think? If Kibana should support package-level vars as part of phase 1, can you provide some guidance on how they fit into the existing policy editor UI?

[kaiyan-sheng]

@jen-huang My understanding is, for package-level vars, I would expect to see them under current Integration settings. So basically moving Credential Profile Name and Advanced options from under Settings per logs/metrics up a level.

[jen-huang]

Thanks @kaiyan-sheng, I think that makes sense. I've added supporting package-level vars to the Kibana scope for phase 1: elastic/kibana#93315

[kaiyan-sheng]

Hi @kaiyan-sheng, please add input_groups as part of these changes too. Without this field, Kibana won't know what to display in the UI. For more context: elastic/package-registry#685 (comment)

@jen-huang Done, please let me know if it works for you! Thank you!!

[mtojek]

@kaiyan-sheng Do input groups need a newer stack (7.14.0-SNAPSHOT)? If so, we need to bump it out in elastic-package. It's not a problem at all, but just asking in advance ;)

[kaiyan-sheng]

Thanks for pointing this out @mtojek ! Yes we do need to limit the stack version. I'm thinking to change the kibana.version in manifest.yml to be ^7.14.0. Let's wait till @jen-huang 's PR get merged first before bumping the version here.

[jen-huang]

FYI elastic/kibana#99866 is just the first part of the Kibana work, there is a second part to come :)

[ChrsMark]

lgtm, however conflicts should be resolved

[ChrsMark]