-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloudnative] Update null checks and if checks in the rename processor #7956
[Cloudnative] Update null checks and if checks in the rename processor #7956
Conversation
🌐 Coverage report
|
I would expect some test evidence like a grok test or sth that this change worked. Apart from that is ok. |
I have added the testing to the PR description. |
Package istio - 0.4.2 containing this change is available at https://epr.elastic.co/search?package=istio |
Package nats - 1.3.2 containing this change is available at https://epr.elastic.co/search?package=nats |
Package nginx_ingress_controller - 1.7.3 containing this change is available at https://epr.elastic.co/search?package=nginx_ingress_controller |
Package stan - 1.3.2 containing this change is available at https://epr.elastic.co/search?package=stan |
What does this PR do?
This PR adds the if check for event.original and the ignore_missing check for the renaming of message to event.original
The packages where the changes are made are as below:
Checklist
changelog.yml
file.Testing
After adding the check if event.original is null, it takes value of message as shown below:
If event.original is present. For testing it was set in the pipeline itself as below:
As a result the event.original has the original value and not the message value.
Related issues