-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update (most) obs-cloud-monitoring owned packages to format_version 3.0.0 #8041
Update (most) obs-cloud-monitoring owned packages to format_version 3.0.0 #8041
Conversation
The format_version in the package manifest changed from 1.0.0 to 3.0.0. Removed dotted YAML keys from package manifest. Added 'owner.type: elastic' to package manifest. [git-generate] go run github.com/andrewkroh/go-examples/ecs-update@v0.0.0-20230926022833-8e5b97998cc0 -format-version=3.0.0 -fix-dotted-yaml-keys -add-owner-type packages/aws_logs
The format_version in the package manifest changed from 1.0.0 to 3.0.0. Removed dotted YAML keys from package manifest. Added 'owner.type: elastic' to package manifest. [git-generate] go run github.com/andrewkroh/go-examples/ecs-update@v0.0.0-20230926022833-8e5b97998cc0 -format-version=3.0.0 -fix-dotted-yaml-keys -add-owner-type packages/awsfargate
The format_version in the package manifest changed from 2.9.0 to 3.0.0. Removed dotted YAML keys from package manifest. Added 'owner.type: elastic' to package manifest. [git-generate] go run github.com/andrewkroh/go-examples/ecs-update@v0.0.0-20230926022833-8e5b97998cc0 -format-version=3.0.0 -fix-dotted-yaml-keys -add-owner-type packages/awsfirehose
The format_version in the package manifest changed from 2.9.0 to 3.0.0. Removed dotted YAML keys from package manifest. Added 'owner.type: elastic' to package manifest. [git-generate] go run github.com/andrewkroh/go-examples/ecs-update@v0.0.0-20230926022833-8e5b97998cc0 -format-version=3.0.0 -fix-dotted-yaml-keys -add-owner-type packages/azure_application_insights
The format_version in the package manifest changed from 2.9.0 to 3.0.0. Removed dotted YAML keys from package manifest. Added 'owner.type: elastic' to package manifest. [git-generate] go run github.com/andrewkroh/go-examples/ecs-update@v0.0.0-20230926022833-8e5b97998cc0 -format-version=3.0.0 -fix-dotted-yaml-keys -add-owner-type packages/azure_billing
The format_version in the package manifest changed from 2.0.0 to 3.0.0. Removed dotted YAML keys from package manifest. Added 'owner.type: elastic' to package manifest. [git-generate] go run github.com/andrewkroh/go-examples/ecs-update@v0.0.0-20230926022833-8e5b97998cc0 -format-version=3.0.0 -fix-dotted-yaml-keys -add-owner-type packages/gcp_metrics
The format_version in the package manifest changed from 1.0.0 to 3.0.0. Removed dotted YAML keys from package manifest. Added 'owner.type: elastic' to package manifest. [git-generate] go run github.com/andrewkroh/go-examples/ecs-update@v0.0.0-20230926022833-8e5b97998cc0 -format-version=3.0.0 -fix-dotted-yaml-keys -add-owner-type packages/azure_metrics
packages/azure_metrics/data_stream/container_instance/fields/package-fields.yml
Outdated
Show resolved
Hide resolved
packages/azure_metrics/data_stream/container_registry/fields/agent.yml
Outdated
Show resolved
Hide resolved
packages/azure_metrics/data_stream/storage_account/fields/agent.yml
Outdated
Show resolved
Hide resolved
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@tommyers-elastic, do you plan to address the platformlogs' _dev/test/pipeline/test-platformlogs-invalid-raw.log
malformed JSON issues on in a different PR?
IIRC, the test fails on stack versions > 8.6 because the json
processor in Elasticsearch has become stricter by default starting from 8.7.
More on this issue at zmoog/public-notes#54
hey @zmoog yeh i have another PR just for azure because it contains quite a few more changes. i haven't addressed the malformed log issue there yet, but i will get round to it soon. |
@tommyers-elastic, I mentioned it so we do not forget it. Happy to help with a review! |
462fc6a
to
ed1b1fc
Compare
ed1b1fc
to
f98d4e6
Compare
...s/azure_application_insights/data_stream/app_state/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
Package aws_logs - 0.6.0 containing this change is available at https://epr.elastic.co/search?package=aws_logs |
Package awsfargate - 0.4.0 containing this change is available at https://epr.elastic.co/search?package=awsfargate |
Package awsfirehose - 0.5.0 containing this change is available at https://epr.elastic.co/search?package=awsfirehose |
Package azure_application_insights - 1.2.0 containing this change is available at https://epr.elastic.co/search?package=azure_application_insights |
Package azure_billing - 1.3.0 containing this change is available at https://epr.elastic.co/search?package=azure_billing |
Package gcp_metrics - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=gcp_metrics |
This PR updates all obs-cloud-monitoring owned packages, except
azure
andazure_metrics
, to package spec v3.These changes are mostly autogenerated in three stages.
Firstly we run
elastic-package format
on everything. This commit can be excluded from review to make the diff cleaner.Then the following
yq
commands are run across all the affected packages:ecs-update
tool is run as follows:Any remaining issues were fixed manually. Even though most of the changes here were generated by tooling, this still needs careful review (hide whitespace changes to make your life easier).
There should be no functional changes to any of the packages here.
Checklist
changelog.yml
file.