-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[system] Adds tags.yml
file so they appear under the Security Solution UI and upgrades package spec to version 3.0.0
#8206
Conversation
db2d4f5
to
ff767db
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
tags.yml
file so they appear under the Security Solution UI and upgrades package spec to version 3.0.0
🌐 Coverage report
|
/test |
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
@jsoriano @mrodm It seems to me the errors we got |
@marc-gr this is likely a side effect of elastic/elastic-package#1485. Try running I am currently looking into making this automation a bit smarter. In the meantime you can workaround the issue by quoting the keys that the automation is converting to objects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
@@ -2,6 +2,5 @@ fields: | |||
event: | |||
timezone: "+0000" | |||
dynamic_fields: | |||
event: | |||
ingested: "^.*$" | |||
event.ingested: "^.*$" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is funny. I take it that this is needed because it's essentially treated as a literal key rather than a path. Is that correct?
[a few moments later]
I see this is correct in the next commit.
event: | ||
timezone: "+0000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to only fail for dynamic_fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have reverted the change in elastic-package
that was requiring all these changes in test config files. So you can also revert all these changes, they should not be needed anymore.
Package system - 1.45.0 containing this change is available at https://epr.elastic.co/search?package=system |
Proposed commit message
Adds
tags.yml
file so they appear under the Security Solution UI and upgrades package spec to version 3.0.0. Required changes include:env
object type to flattened.Checklist
changelog.yml
file.Related issues