[ML] Fix annotation table in job list not having terms

elastic · Jul 9, 2020 · 02024e5 · 02024e5
1 parent aa98817
commit 02024e5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 16 deletions.
diff --git a/x-pack/plugins/ml/common/constants/annotations.ts b/x-pack/plugins/ml/common/constants/annotations.ts
@@ -15,3 +15,4 @@ export const ANNOTATION_USER_UNKNOWN = '<user unknown>';
 export const ANNOTATION_MAX_LENGTH_CHARS = 1000;
 
 export const ANNOTATION_EVENT_USER = 'user';
+export const ANNOTATION_EVENT_DELAYED_DATA = 'delayed_data';
diff --git a/...ugins/ml/public/application/components/annotations/annotations_table/annotations_table.js b/...ugins/ml/public/application/components/annotations/annotations_table/annotations_table.js
@@ -69,6 +69,7 @@ export class AnnotationsTable extends Component {
     super(props);
     this.state = {
       annotations: [],
+      aggregations: null,
       isLoading: false,
       queryText: `event:(${ANNOTATION_EVENT_USER} or ${ANNOTATION_EVENT_DELAYED_DATA})`,
       searchError: undefined,
@@ -111,6 +112,7 @@ export class AnnotationsTable extends Component {
         .then((resp) => {
           this.setState((prevState, props) => ({
             annotations: resp.annotations[props.jobs[0].job_id] || [],
+            aggregations: resp.aggregations,
             errorMessage: undefined,
             isLoading: false,
             jobId: props.jobs[0].job_id,
@@ -518,8 +520,9 @@ export class AnnotationsTable extends Component {
       };
     };
     let filterOptions = [];
-    if (this.props.aggregations?.event?.buckets) {
-      const buckets = this.props.aggregations.event.buckets;
+    const aggregations = this.props.aggregations ?? this.state.aggregations;
+    if (aggregations) {
+      const buckets = aggregations.event.buckets;
       const foundUser = buckets.findIndex((d) => d.key === ANNOTATION_EVENT_USER) > -1;
       filterOptions = foundUser
         ? buckets

diff --git a/x-pack/plugins/ml/public/application/services/ml_api_service/annotations.ts b/x-pack/plugins/ml/public/application/services/ml_api_service/annotations.ts
@@ -6,7 +6,6 @@
 
 import {
   Annotation,
-  EsAggregationResult,
   FieldToBucket,
   GetAnnotationsResponse,
 } from '../../../../common/types/annotations';
@@ -28,19 +27,6 @@ export const annotations = {
       body,
     });
   },
-  getUniqueAnnotationTerms(obj: {
-    jobIds: string[];
-    earliestMs: number;
-    latestMs: number;
-    fields: FieldToBucket[];
-  }) {
-    const body = JSON.stringify(obj);
-    return http$<{ annotationTerms: Record<string, EsAggregationResult> }>({
-      path: `${basePath()}/annotations/terms`,
-      method: 'POST',
-      body,
-    });
-  },
 
   indexAnnotation(obj: Annotation) {
     const body = JSON.stringify(obj);