flag packages without side effects (#173351)

## Summary Add the `sideEffects` meta to packages without side effects to optimize tree-shaking on browser-side bundles. Notes: - it mostly impacts the `securitySolution` app (almost 2mb reduction) - it's not always beneficial for all apps, some apps gain some weight, likely related to the way webpack optimizes the chunks, but I feel like it's still overall beneficial (don't hesitate to say if you think otherwise) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
elastic · Dec 19, 2023 · 02bafbd · 02bafbd
1 parent cd02e8d
commit 02bafbd
Show file tree

Hide file tree

Showing 32 changed files with 69 additions and 31 deletions.
diff --git a/packages/kbn-analytics/package.json b/packages/kbn-analytics/package.json
@@ -4,5 +4,6 @@
   "version": "1.0.0",
   "description": "Kibana Analytics tool",
   "author": "Kibana Core",
-  "license": "SSPL-1.0 OR Elastic License 2.0"
+  "license": "SSPL-1.0 OR Elastic License 2.0",
+  "sideEffects": false
 }
diff --git a/packages/kbn-crypto-browser/package.json b/packages/kbn-crypto-browser/package.json
@@ -2,5 +2,6 @@
   "name": "@kbn/crypto-browser",
   "private": true,
   "version": "1.0.0",
-  "license": "SSPL-1.0 OR Elastic License 2.0"
+  "license": "SSPL-1.0 OR Elastic License 2.0",
+  "sideEffects": false
 }
diff --git a/packages/kbn-custom-integrations/package.json b/packages/kbn-custom-integrations/package.json
@@ -2,5 +2,6 @@
   "name": "@kbn/custom-integrations",
   "private": true,
   "version": "1.0.0",
-  "license": "SSPL-1.0 OR Elastic License 2.0"
+  "license": "SSPL-1.0 OR Elastic License 2.0",
+  "sideEffects": false
 }
diff --git a/packages/kbn-dom-drag-drop/package.json b/packages/kbn-dom-drag-drop/package.json
@@ -2,5 +2,8 @@
   "name": "@kbn/dom-drag-drop",
   "private": true,
   "version": "1.0.0",
-  "license": "SSPL-1.0 OR Elastic License 2.0"
+  "license": "SSPL-1.0 OR Elastic License 2.0",
+  "sideEffects": [
+    "*.scss"
+  ]
 }
diff --git a/packages/kbn-es-query/package.json b/packages/kbn-es-query/package.json
@@ -2,5 +2,6 @@
   "name": "@kbn/es-query",
   "version": "1.0.0",
   "license": "SSPL-1.0 OR Elastic License 2.0",
-  "private": true
+  "private": true,
+  "sideEffects": false
 }
diff --git a/packages/kbn-expandable-flyout/package.json b/packages/kbn-expandable-flyout/package.json
@@ -2,5 +2,6 @@
   "name": "@kbn/expandable-flyout",
   "private": true,
   "version": "1.0.0",
-  "license": "SSPL-1.0 OR Elastic License 2.0"
+  "license": "SSPL-1.0 OR Elastic License 2.0",
+  "sideEffects": false
 }
diff --git a/packages/kbn-guided-onboarding/package.json b/packages/kbn-guided-onboarding/package.json
@@ -2,5 +2,6 @@
   "name": "@kbn/guided-onboarding",
   "private": true,
   "version": "1.0.0",
-  "license": "SSPL-1.0 OR Elastic License 2.0"
+  "license": "SSPL-1.0 OR Elastic License 2.0",
+  "sideEffects": false
 }
diff --git a/packages/kbn-io-ts-utils/package.json b/packages/kbn-io-ts-utils/package.json
@@ -2,5 +2,6 @@
   "name": "@kbn/io-ts-utils",
   "version": "1.0.0",
   "license": "SSPL-1.0 OR Elastic License 2.0",
-  "private": true
+  "private": true,
+  "sideEffects": false
 }
diff --git a/packages/kbn-language-documentation-popover/package.json b/packages/kbn-language-documentation-popover/package.json
@@ -2,5 +2,6 @@
   "name": "@kbn/language-documentation-popover",
   "version": "1.0.0",
   "license": "SSPL-1.0 OR Elastic License 2.0",
-  "private": true
+  "private": true,
+  "sideEffects": false
 }
diff --git a/packages/kbn-logging/package.json b/packages/kbn-logging/package.json
@@ -3,5 +3,6 @@
   "version": "1.0.0",
   "private": true,
   "author": "Kibana Core",
-  "license": "SSPL-1.0 OR Elastic License 2.0"
+  "license": "SSPL-1.0 OR Elastic License 2.0",
+  "sideEffects": false
 }
diff --git a/packages/kbn-profiling-utils/package.json b/packages/kbn-profiling-utils/package.json
@@ -2,5 +2,6 @@
   "name": "@kbn/profiling-utils",
   "private": true,
   "version": "1.0.0",
-  "license": "SSPL-1.0 OR Elastic License 2.0"
+  "license": "SSPL-1.0 OR Elastic License 2.0",
+  "sideEffects": false
 }
diff --git a/packages/kbn-resizable-layout/package.json b/packages/kbn-resizable-layout/package.json
@@ -2,5 +2,6 @@
   "name": "@kbn/resizable-layout",
   "private": true,
   "version": "1.0.0",
-  "license": "SSPL-1.0 OR Elastic License 2.0"
+  "license": "SSPL-1.0 OR Elastic License 2.0",
+  "sideEffects": false
 }
diff --git a/packages/kbn-rule-data-utils/package.json b/packages/kbn-rule-data-utils/package.json
@@ -2,5 +2,6 @@
   "name": "@kbn/rule-data-utils",
   "version": "1.0.0",
   "license": "SSPL-1.0 OR Elastic License 2.0",
-  "private": true
+  "private": true,
+  "sideEffects": false
 }
diff --git a/packages/kbn-search-index-documents/package.json b/packages/kbn-search-index-documents/package.json
@@ -2,5 +2,8 @@
   "name": "@kbn/search-index-documents",
   "private": true,
   "version": "1.0.0",
-  "license": "SSPL-1.0 OR Elastic License 2.0"
+  "license": "SSPL-1.0 OR Elastic License 2.0",
+  "sideEffects": [
+    "*.scss"
+  ]
 }
diff --git a/packages/kbn-search-response-warnings/package.json b/packages/kbn-search-response-warnings/package.json
@@ -2,5 +2,8 @@
   "name": "@kbn/search-response-warnings",
   "private": true,
   "version": "1.0.0",
-  "license": "SSPL-1.0 OR Elastic License 2.0"
+  "license": "SSPL-1.0 OR Elastic License 2.0",
+  "sideEffects": [
+    "*.scss"
+  ]
 }
diff --git a/packages/kbn-securitysolution-autocomplete/package.json b/packages/kbn-securitysolution-autocomplete/package.json
@@ -3,5 +3,6 @@
   "version": "1.0.0",
   "description": "Security Solution auto complete",
   "license": "SSPL-1.0 OR Elastic License 2.0",
-  "private": true
+  "private": true,
+  "sideEffects": false
 }
diff --git a/packages/kbn-securitysolution-ecs/package.json b/packages/kbn-securitysolution-ecs/package.json
@@ -2,5 +2,6 @@
   "name": "@kbn/securitysolution-ecs",
   "private": true,
   "version": "1.0.0",
-  "license": "SSPL-1.0 OR Elastic License 2.0"
+  "license": "SSPL-1.0 OR Elastic License 2.0",
+  "sideEffects": false
 }
diff --git a/packages/kbn-securitysolution-es-utils/package.json b/packages/kbn-securitysolution-es-utils/package.json
@@ -3,5 +3,6 @@
   "version": "1.0.0",
   "description": "security solution elastic search utilities to use across plugins such lists, security_solution, cases, etc...",
   "license": "SSPL-1.0 OR Elastic License 2.0",
-  "private": true
+  "private": true,
+  "sideEffects": false
 }
diff --git a/packages/kbn-securitysolution-exception-list-components/package.json b/packages/kbn-securitysolution-exception-list-components/package.json
@@ -2,5 +2,6 @@
   "name": "@kbn/securitysolution-exception-list-components",
   "private": true,
   "version": "1.0.0",
-  "license": "SSPL-1.0 OR Elastic License 2.0"
+  "license": "SSPL-1.0 OR Elastic License 2.0",
+  "sideEffects": false
 }
diff --git a/packages/kbn-securitysolution-grouping/package.json b/packages/kbn-securitysolution-grouping/package.json
@@ -2,5 +2,6 @@
   "name": "@kbn/securitysolution-grouping",
   "private": true,
   "version": "1.0.0",
-  "license": "SSPL-1.0 OR Elastic License 2.0"
+  "license": "SSPL-1.0 OR Elastic License 2.0",
+  "sideEffects": false
 }
diff --git a/packages/kbn-securitysolution-hook-utils/package.json b/packages/kbn-securitysolution-hook-utils/package.json
@@ -3,5 +3,6 @@
   "version": "1.0.0",
   "description": "Security Solution utilities for React hooks",
   "license": "SSPL-1.0 OR Elastic License 2.0",
-  "private": true
+  "private": true,
+  "sideEffects": false
 }
diff --git a/packages/kbn-securitysolution-io-ts-alerting-types/package.json b/packages/kbn-securitysolution-io-ts-alerting-types/package.json
@@ -3,5 +3,6 @@
   "version": "1.0.0",
   "description": "io ts utilities and types to be shared with plugins from the security solution project",
   "license": "SSPL-1.0 OR Elastic License 2.0",
-  "private": true
+  "private": true,
+  "sideEffects": false
 }
diff --git a/packages/kbn-securitysolution-io-ts-list-types/package.json b/packages/kbn-securitysolution-io-ts-list-types/package.json
@@ -3,5 +3,6 @@
   "version": "1.0.0",
   "description": "io ts utilities and types to be shared with plugins from the security solution project",
   "license": "SSPL-1.0 OR Elastic License 2.0",
-  "private": true
+  "private": true,
+  "sideEffects": false
 }
diff --git a/packages/kbn-securitysolution-io-ts-types/package.json b/packages/kbn-securitysolution-io-ts-types/package.json
@@ -3,5 +3,6 @@
   "version": "1.0.0",
   "description": "io ts utilities and types to be shared with plugins from the security solution project",
   "license": "SSPL-1.0 OR Elastic License 2.0",
-  "private": true
+  "private": true,
+  "sideEffects": false
 }
diff --git a/packages/kbn-securitysolution-io-ts-utils/package.json b/packages/kbn-securitysolution-io-ts-utils/package.json
@@ -3,5 +3,6 @@
   "version": "1.0.0",
   "description": "io ts utilities and types to be shared with plugins from the security solution project",
   "license": "SSPL-1.0 OR Elastic License 2.0",
-  "private": true
+  "private": true,
+  "sideEffects": false
 }
diff --git a/packages/kbn-securitysolution-list-hooks/package.json b/packages/kbn-securitysolution-list-hooks/package.json
@@ -3,5 +3,6 @@
   "version": "1.0.0",
   "description": "Security solution list ReactJS hooks",
   "license": "SSPL-1.0 OR Elastic License 2.0",
-  "private": true
+  "private": true,
+  "sideEffects": false
 }
diff --git a/packages/kbn-securitysolution-list-utils/package.json b/packages/kbn-securitysolution-list-utils/package.json
@@ -3,5 +3,6 @@
   "version": "1.0.0",
   "description": "security solution list utilities",
   "license": "SSPL-1.0 OR Elastic License 2.0",
-  "private": true
+  "private": true,
+  "sideEffects": false
 }
diff --git a/packages/kbn-securitysolution-utils/package.json b/packages/kbn-securitysolution-utils/package.json
@@ -3,5 +3,6 @@
   "version": "1.0.0",
   "description": "security solution utilities to use across plugins such lists, security_solution, cases, etc...",
   "license": "SSPL-1.0 OR Elastic License 2.0",
-  "private": true
+  "private": true,
+  "sideEffects": false
 }
diff --git a/packages/kbn-shared-ux-utility/package.json b/packages/kbn-shared-ux-utility/package.json
@@ -2,5 +2,6 @@
   "name": "@kbn/shared-ux-utility",
   "private": true,
   "version": "1.0.0",
-  "license": "SSPL-1.0 OR Elastic License 2.0"
+  "license": "SSPL-1.0 OR Elastic License 2.0",
+  "sideEffects": false
 }
diff --git a/packages/kbn-std/package.json b/packages/kbn-std/package.json
@@ -3,5 +3,6 @@
   "version": "1.0.0",
   "author": "Kibana Core",
   "license": "SSPL-1.0 OR Elastic License 2.0",
+  "sideEffects": false,
   "private": true
 }
diff --git a/packages/kbn-user-profile-components/package.json b/packages/kbn-user-profile-components/package.json
@@ -2,5 +2,6 @@
   "name": "@kbn/user-profile-components",
   "version": "1.0.0",
   "private": true,
-  "license": "SSPL-1.0 OR Elastic License 2.0"
+  "license": "SSPL-1.0 OR Elastic License 2.0",
+  "sideEffects": false
 }
diff --git a/packages/kbn-zod-helpers/package.json b/packages/kbn-zod-helpers/package.json
@@ -3,5 +3,6 @@
   "license": "SSPL-1.0 OR Elastic License 2.0",
   "name": "@kbn/zod-helpers",
   "private": true,
-  "version": "1.0.0"
+  "version": "1.0.0",
+  "sideEffects": false
 }