reset settings when navigate to choose-settings-step page

elastic · May 6, 2020 · 0480641 · 0480641
1 parent 3e9a12c
commit 0480641
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/...public/components/app/Settings/AgentConfigurations/AgentConfigurationCreateEdit/index.tsx b/...public/components/app/Settings/AgentConfigurations/AgentConfigurationCreateEdit/index.tsx
@@ -86,6 +86,17 @@ export function AgentConfigurationCreateEdit({
     setNewConfig(getInitialNewConfig(existingConfig));
   }, [existingConfig]);
 
+  useEffect(
+    () => {
+      // cleanup settings when navigating to "choose-settings-step" to not save invalid configurations
+      if (pageStep === 'choose-settings-step' && !isEditMode) {
+        setNewConfig({ ...newConfig, settings: {} });
+      }
+    },
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+    [pageStep]
+  );
+
   useEffect(() => {
     // the user tried to edit the service of an existing config
     if (pageStep === 'choose-service-step' && isEditMode) {
@@ -100,7 +111,7 @@ export function AgentConfigurationCreateEdit({
     ) {
       setPage('choose-service-step');
     }
-  }, [isEditMode, newConfig, pageStep]);
+  }, [existingConfig, isEditMode, newConfig, pageStep]);
 
   const unsavedChanges = getUnsavedChanges({ newConfig, existingConfig });