Replace "Save and return" button with "Save" for Lens visualization c…

…reated from Discover histogram to avoid confusion
elastic · Mar 31, 2022 · 05064c6 · 05064c6
1 parent cef1d43
commit 05064c6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/plugins/discover/public/application/main/components/chart/discover_chart.tsx b/src/plugins/discover/public/application/main/components/chart/discover_chart.tsx
@@ -83,7 +83,7 @@ export function DiscoverChart({
     if (!timeField) {
       return;
     }
-    triggerVisualizeActions(timeField, indexPattern.id, savedSearch.columns || []);
+    triggerVisualizeActions(timeField, indexPattern.id, savedSearch.columns || [], false);
   }, [indexPattern.id, savedSearch, timeField]);
 
   const onShowChartOptions = useCallback(() => {

diff --git a/...lugins/discover/public/application/main/components/sidebar/lib/visualize_trigger_utils.ts b/...lugins/discover/public/application/main/components/sidebar/lib/visualize_trigger_utils.ts
@@ -46,15 +46,20 @@ async function getCompatibleActions(
 export function triggerVisualizeActions(
   field: DataViewField,
   indexPatternId: string | undefined,
-  contextualFields: string[]
+  contextualFields: string[],
+  shouldPassOriginatingApp: boolean = true
 ) {
   if (!indexPatternId) return;
   const trigger = getTriggerConstant(field.type);
   const triggerOptions = {
     indexPatternId,
     fieldName: field.name,
     contextualFields,
-    originatingApp: APP_ID,
+    ...(shouldPassOriginatingApp
+      ? {
+          originatingApp: APP_ID,
+        }
+      : {}),
   };
   getUiActions().getTrigger(trigger).exec(triggerOptions);
 }