Fix task manager query to return tasks to retry (#63360) (#63405)

* Fix task manager query to also return tasks to retry * Fix failing jest tests
elastic · Apr 13, 2020 · 051d9f6 · 051d9f6
1 parent e68fe90
commit 051d9f6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/x-pack/plugins/task_manager/server/queries/mark_available_tasks_as_claimed.ts b/x-pack/plugins/task_manager/server/queries/mark_available_tasks_as_claimed.ts
@@ -11,7 +11,7 @@ import {
   RangeFilter,
   mustBeAllOf,
   MustCondition,
-  MustNotCondition,
+  BoolClauseWithAnyCondition,
 } from './query_clauses';
 
 export const TaskWithSchedule: ExistsFilter = {
@@ -54,15 +54,16 @@ export const IdleTaskWithExpiredRunAt: MustCondition<TermFilter | RangeFilter> =
   },
 };
 
-export const InactiveTasks: MustNotCondition<TermFilter | RangeFilter> = {
+// TODO: Fix query clauses to support this
+export const InactiveTasks: BoolClauseWithAnyCondition<any> = {
   bool: {
     must_not: [
       {
         bool: {
           should: [{ term: { 'task.status': 'running' } }, { term: { 'task.status': 'claiming' } }],
+          must: { range: { 'task.retryAt': { gt: 'now' } } },
         },
       },
-      { range: { 'task.retryAt': { gt: 'now' } } },
     ],
   },
 };

diff --git a/x-pack/plugins/task_manager/server/task_store.test.ts b/x-pack/plugins/task_manager/server/task_store.test.ts
@@ -407,9 +407,9 @@ describe('TaskStore', () => {
                               { term: { 'task.status': 'running' } },
                               { term: { 'task.status': 'claiming' } },
                             ],
+                            must: { range: { 'task.retryAt': { gt: 'now' } } },
                           },
                         },
-                        { range: { 'task.retryAt': { gt: 'now' } } },
                       ],
                     },
                   },
@@ -553,9 +553,9 @@ describe('TaskStore', () => {
                               { term: { 'task.status': 'running' } },
                               { term: { 'task.status': 'claiming' } },
                             ],
+                            must: { range: { 'task.retryAt': { gt: 'now' } } },
                           },
                         },
-                        { range: { 'task.retryAt': { gt: 'now' } } },
                       ],
                     },
                   },