test: fix @elastic/charts mock including themes objects

elastic · Mar 16, 2020 · 059e34d · 059e34d
1 parent 3bd5f54
commit 059e34d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/...s/vis_type_timeseries/public/visualizations/views/timeseries/__mocks__/@elastic/charts.js b/...s/vis_type_timeseries/public/visualizations/views/timeseries/__mocks__/@elastic/charts.js
@@ -40,3 +40,5 @@ export const ScaleType = {
 
 export const BarSeries = () => null;
 export const AreaSeries = () => null;
+
+export { LIGHT_THEME, DARK_THEME } from '@elastic/charts';
diff --git a/...re_plugins/vis_type_timeseries/public/visualizations/views/timeseries/utils/theme.test.ts b/...re_plugins/vis_type_timeseries/public/visualizations/views/timeseries/utils/theme.test.ts
@@ -33,7 +33,7 @@ describe('TSVB theme', () => {
   });
   it('should return a highcontrast color theme for a different background', () => {
     // red use a near full-black color
-    expect(getTheme(false, 'red').axes.axisTitleStyle.fill).toEqual('rgb(25,25,25)');
+    expect(getTheme(false, 'red').axes.axisTitleStyle.fill).toEqual('rgb(23,23,23)');
 
     // violet increased the text color to full white for higer contrast
     expect(getTheme(false, '#ba26ff').axes.axisTitleStyle.fill).toEqual('rgb(255,255,255)');

diff --git a/...cy/core_plugins/vis_type_timeseries/public/visualizations/views/timeseries/utils/theme.ts b/...cy/core_plugins/vis_type_timeseries/public/visualizations/views/timeseries/utils/theme.ts
@@ -82,6 +82,9 @@ function isValidColor(color: string | null | undefined): color is string {
   if (typeof color !== 'string') {
     return false;
   }
+  if (color.length === 0) {
+    return false;
+  }
   try {
     colorJS(color);
     return true;
Original file line number	Diff line number	Diff line change
Expand Up		@@ -40,3 +40,5 @@ export const ScaleType = {

		export const BarSeries = () => null;
		export const AreaSeries = () => null;

		export { LIGHT_THEME, DARK_THEME } from '@elastic/charts';