Skip to content

Commit

Permalink
Import EuiCodeEditor from kibana (#108846)
Browse files Browse the repository at this point in the history
  • Loading branch information
stratoula authored Aug 17, 2021
1 parent 8bfd5e2 commit 0640a11
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/plugins/advanced_settings/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"ui": true,
"requiredPlugins": ["management"],
"optionalPlugins": ["home", "usageCollection"],
"requiredBundles": ["kibanaReact", "kibanaUtils", "home"],
"requiredBundles": ["kibanaReact", "kibanaUtils", "home", "esUiShared"],
"owner": {
"name": "Kibana App",
"githubTeam": "kibana-app"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

import React, { PureComponent, Fragment } from 'react';
import classNames from 'classnames';

import 'brace/theme/textmate';
import 'brace/mode/markdown';
import 'brace/mode/json';
Expand All @@ -19,7 +18,6 @@ import {
EuiCodeBlock,
EuiColorPicker,
EuiScreenReaderOnly,
EuiCodeEditor,
EuiDescribedFormGroup,
EuiFieldNumber,
EuiFieldText,
Expand All @@ -40,6 +38,7 @@ import { FormattedMessage } from '@kbn/i18n/react';
import { FieldSetting, FieldState } from '../../types';
import { isDefaultValue } from '../../lib';
import { UiSettingsType, DocLinksStart, ToastsStart } from '../../../../../../core/public';
import { EuiCodeEditor } from '../../../../../es_ui_shared/public';

interface FieldProps {
setting: FieldSetting;
Expand Down
1 change: 1 addition & 0 deletions src/plugins/advanced_settings/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@
{ "path": "../home/tsconfig.json" },
{ "path": "../usage_collection/tsconfig.json" },
{ "path": "../kibana_react/tsconfig.json" },
{ "path": "../es_ui_shared/tsconfig.json" },
]
}
2 changes: 1 addition & 1 deletion src/plugins/vis_type_vega/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"ui": true,
"requiredPlugins": ["data", "visualizations", "mapsEms", "expressions", "inspector"],
"optionalPlugins": ["home","usageCollection"],
"requiredBundles": ["kibanaUtils", "kibanaReact", "visDefaultEditor"],
"requiredBundles": ["kibanaUtils", "kibanaReact", "visDefaultEditor", "esUiShared"],
"owner": {
"name": "Kibana App",
"githubTeam": "kibana-app"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
*/

import React, { useCallback } from 'react';
import { EuiCodeEditor } from '@elastic/eui';
import compactStringify from 'json-stringify-pretty-compact';
import hjson from 'hjson';
import 'brace/mode/hjson';
import { i18n } from '@kbn/i18n';

import { VisEditorOptionsProps } from 'src/plugins/visualizations/public';
import { EuiCodeEditor } from '../../../es_ui_shared/public';
import { getNotifications } from '../services';
import { VisParams } from '../vega_fn';
import { VegaHelpMenu } from './vega_help_menu';
Expand Down
1 change: 1 addition & 0 deletions src/plugins/vis_type_vega/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,6 @@
{ "path": "../kibana_utils/tsconfig.json" },
{ "path": "../kibana_react/tsconfig.json" },
{ "path": "../vis_default_editor/tsconfig.json" },
{ "path": "../es_ui_shared/tsconfig.json" },
]
}

0 comments on commit 0640a11

Please sign in to comment.