remove duplicate tab states

elastic · Oct 5, 2020 · 0a43a3c · 0a43a3c
1 parent a8b1b9e
commit 0a43a3c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/...line_processors_editor/components/test_pipeline/documents_dropdown/documents_dropdown.tsx b/...line_processors_editor/components/test_pipeline/documents_dropdown/documents_dropdown.tsx
@@ -27,7 +27,7 @@ const i18nTexts = {
       defaultMessage: 'Documents:',
     }
   ),
-  addDocumentsButtonLabel: i18n.translate(
+  editDocumentsButtonLabel: i18n.translate(
     'xpack.ingestPipelines.pipelineEditor.testPipeline.documentsDropdown.editDocumentsButtonLabel',
     {
       defaultMessage: 'Edit documents',
@@ -124,7 +124,7 @@ export const DocumentsDropdown: FunctionComponent<Props> = ({
           }}
           data-test-subj="editDocumentsButton"
         >
-          {i18nTexts.addDocumentsButtonLabel}
+          {i18nTexts.editDocumentsButtonLabel}
         </EuiButton>
       </EuiPopoverFooter>
     </EuiPopover>

diff --git a/.../components/pipeline_processors_editor/components/test_pipeline/test_pipeline_actions.tsx b/.../components/pipeline_processors_editor/components/test_pipeline/test_pipeline_actions.tsx
@@ -88,6 +88,7 @@ export const TestPipelineActions: FunctionComponent = () => {
       {openTestPipelineFlyout && (
         <TestPipelineFlyout
           activeTab={activeFlyoutTab}
+          setActiveTab={setActiveFlyoutTab}
           processors={{
             processors: processors.state.processors,
             onFailure: processors.state.onFailure,

diff --git a/...ts/pipeline_processors_editor/components/test_pipeline/test_pipeline_flyout.container.tsx b/...ts/pipeline_processors_editor/components/test_pipeline/test_pipeline_flyout.container.tsx
@@ -19,6 +19,7 @@ import { TestPipelineFlyoutTab } from './test_pipeline_tabs';
 
 export interface Props {
   activeTab: TestPipelineFlyoutTab;
+  setActiveTab: (tab: TestPipelineFlyoutTab) => void;
   onClose: () => void;
   processors: DeserializeResult;
 }
@@ -31,6 +32,7 @@ export interface TestPipelineConfig {
 export const TestPipelineFlyout: React.FunctionComponent<Props> = ({
   onClose,
   activeTab,
+  setActiveTab,
   processors,
 }) => {
   const { services } = useKibana();
@@ -52,8 +54,6 @@ export const TestPipelineFlyout: React.FunctionComponent<Props> = ({
     },
   });
 
-  const [selectedTab, setSelectedTab] = useState<TestPipelineFlyoutTab>(activeTab);
-
   const [isRunningTest, setIsRunningTest] = useState<boolean>(false);
   const [testingError, setTestingError] = useState<any>(null);
   const [testOutput, setTestOutput] = useState<any>(undefined);
@@ -151,7 +151,7 @@ export const TestPipelineFlyout: React.FunctionComponent<Props> = ({
     });
 
     if (isSuccessful) {
-      setSelectedTab('output');
+      setActiveTab('output');
     }
   };
 
@@ -180,8 +180,8 @@ export const TestPipelineFlyout: React.FunctionComponent<Props> = ({
       testOutput={testOutput}
       form={form}
       validateAndTestPipeline={validateAndTestPipeline}
-      selectedTab={selectedTab}
-      setSelectedTab={setSelectedTab}
+      selectedTab={activeTab}
+      setSelectedTab={setActiveTab}
       testingError={testingError}
       onClose={onClose}
     />