use human formats

elastic · Jun 7, 2021 · 0cdf5a5 · 0cdf5a5
1 parent f5dc9d1
commit 0cdf5a5
Show file tree

Hide file tree

Showing 8 changed files with 32 additions and 11 deletions.
diff --git a/...servability/public/components/shared/exploratory_view/configurations/rum/field_formats.ts b/...servability/public/components/shared/exploratory_view/configurations/rum/field_formats.ts
@@ -12,6 +12,7 @@ import {
   LCP_FIELD,
   TBT_FIELD,
   TRANSACTION_DURATION,
+  TRANSACTION_TIME_TO_FIRST_BYTE,
 } from '../constants/elasticsearch_fieldnames';
 
 export const rumFieldFormats: FieldFormat[] = [
@@ -24,6 +25,7 @@ export const rumFieldFormats: FieldFormat[] = [
         outputFormat: 'asSeconds',
         showSuffix: true,
         outputPrecision: 1,
+        useShortSuffix: true,
       },
     },
   },
@@ -33,8 +35,9 @@ export const rumFieldFormats: FieldFormat[] = [
       id: 'duration',
       params: {
         inputFormat: 'milliseconds',
-        outputFormat: 'asSeconds',
+        outputFormat: 'humanizePrecise',
         showSuffix: true,
+        useShortSuffix: true,
       },
     },
   },
@@ -44,8 +47,9 @@ export const rumFieldFormats: FieldFormat[] = [
       id: 'duration',
       params: {
         inputFormat: 'milliseconds',
-        outputFormat: 'asSeconds',
+        outputFormat: 'humanizePrecise',
         showSuffix: true,
+        useShortSuffix: true,
       },
     },
   },
@@ -55,8 +59,9 @@ export const rumFieldFormats: FieldFormat[] = [
       id: 'duration',
       params: {
         inputFormat: 'milliseconds',
-        outputFormat: 'asSeconds',
+        outputFormat: 'humanizePrecise',
         showSuffix: true,
+        useShortSuffix: true,
       },
     },
   },
@@ -66,8 +71,21 @@ export const rumFieldFormats: FieldFormat[] = [
       id: 'duration',
       params: {
         inputFormat: 'milliseconds',
-        outputFormat: 'asSeconds',
+        outputFormat: 'humanizePrecise',
+        showSuffix: true,
+        useShortSuffix: true,
+      },
+    },
+  },
+  {
+    field: TRANSACTION_TIME_TO_FIRST_BYTE,
+    format: {
+      id: 'duration',
+      params: {
+        inputFormat: 'milliseconds',
+        outputFormat: 'humanizePrecise',
         showSuffix: true,
+        useShortSuffix: true,
       },
     },
   },

diff --git a/...ability/public/components/shared/exploratory_view/configurations/rum/kpi_trends_config.ts b/...ability/public/components/shared/exploratory_view/configurations/rum/kpi_trends_config.ts
@@ -44,7 +44,7 @@ export function getKPITrendsLensConfig({ seriesId, indexPattern }: ConfigProps):
     id: seriesId,
     defaultSeriesType: 'bar_stacked',
     reportType: 'kpi-trends',
-    seriesTypes: ['bar', 'bar_stacked'],
+    seriesTypes: [],
     xAxisColumn: {
       sourceField: '@timestamp',
     },

diff --git a/...y/public/components/shared/exploratory_view/configurations/rum/performance_dist_config.ts b/...y/public/components/shared/exploratory_view/configurations/rum/performance_dist_config.ts
@@ -44,7 +44,7 @@ export function getPerformanceDistLensConfig({ seriesId, indexPattern }: ConfigP
     id: seriesId ?? 'unique-key',
     reportType: 'page-load-dist',
     defaultSeriesType: 'line',
-    seriesTypes: ['line', 'bar'],
+    seriesTypes: [],
     xAxisColumn: {
       sourceField: 'performance.metric',
     },

diff --git a/...lity/public/components/shared/exploratory_view/configurations/synthetics/field_formats.ts b/...lity/public/components/shared/exploratory_view/configurations/synthetics/field_formats.ts
@@ -14,9 +14,10 @@ export const syntheticsFieldFormats: FieldFormat[] = [
       id: 'duration',
       params: {
         inputFormat: 'microseconds',
-        outputFormat: 'asMilliseconds',
-        outputPrecision: 0,
+        outputFormat: 'humanizePrecise',
+        outputPrecision: 1,
         showSuffix: true,
+        useShortSuffix: true,
       },
     },
   },

diff --git a/...c/components/shared/exploratory_view/configurations/synthetics/monitor_duration_config.ts b/...c/components/shared/exploratory_view/configurations/synthetics/monitor_duration_config.ts
@@ -15,7 +15,7 @@ export function getMonitorDurationConfig({ seriesId, indexPattern }: ConfigProps
     id: seriesId,
     reportType: 'uptime-duration',
     defaultSeriesType: 'line',
-    seriesTypes: ['line', 'bar_stacked'],
+    seriesTypes: [],
     xAxisColumn: {
       sourceField: '@timestamp',
     },

diff --git a/...blic/components/shared/exploratory_view/configurations/synthetics/monitor_pings_config.ts b/...blic/components/shared/exploratory_view/configurations/synthetics/monitor_pings_config.ts
@@ -15,7 +15,7 @@ export function getMonitorPingsConfig({ seriesId, indexPattern }: ConfigProps):
     id: seriesId,
     reportType: 'uptime-pings',
     defaultSeriesType: 'bar_stacked',
-    seriesTypes: ['bar_stacked', 'bar'],
+    seriesTypes: [],
     xAxisColumn: {
       sourceField: '@timestamp',
     },

diff --git a/x-pack/plugins/observability/public/components/shared/exploratory_view/types.ts b/x-pack/plugins/observability/public/components/shared/exploratory_view/types.ts
@@ -108,13 +108,14 @@ export type AppDataType = 'synthetics' | 'ux' | 'infra_logs' | 'infra_metrics' |
 
 type FormatType = 'duration' | 'number';
 type InputFormat = 'microseconds' | 'milliseconds' | 'seconds';
-type OutputFormat = 'asSeconds' | 'asMilliseconds' | 'humanize';
+type OutputFormat = 'asSeconds' | 'asMilliseconds' | 'humanize' | 'humanizePrecise';
 
 export interface FieldFormatParams {
   inputFormat: InputFormat;
   outputFormat: OutputFormat;
   outputPrecision?: number;
   showSuffix?: boolean;
+  useShortSuffix?: boolean;
 }
 
 export interface FieldFormat {

diff --git a/...rvability/public/components/shared/exploratory_view/utils/observability_index_patterns.ts b/...rvability/public/components/shared/exploratory_view/utils/observability_index_patterns.ts
@@ -60,6 +60,7 @@ export function isParamsSame(param1: IFieldFormat['_params'], param2: FieldForma
   const isSame =
     param1?.inputFormat === param2?.inputFormat &&
     param1?.outputFormat === param2?.outputFormat &&
+    param1?.useShortSuffix === param2?.useShortSuffix &&
     param1?.showSuffix === param2?.showSuffix;
 
   if (param2.outputPrecision !== undefined) {