- Fix Visualize wizard breadcrumbs.

- Use consistent "Create" terminology in both Visualize and Dashboard for creating new items. - Use NoItems and PromptForItems components in Visualize listing view.
elastic · Feb 6, 2017 · 10dbff6 · 10dbff6
1 parent de4f7b4
commit 10dbff6
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 7 deletions.
diff --git a/src/core_plugins/kibana/public/dashboard/listing/dashboard_listing.html b/src/core_plugins/kibana/public/dashboard/listing/dashboard_listing.html
@@ -72,7 +72,7 @@
       </div>
     </div>
 
-    <!-- NoResults -->
+    <!-- NoItems -->
     <div
       class="kuiPanel kuiPanel--centered kuiPanel--withHeader"
       ng-if="!listingController.items.length && listingController.filter"
@@ -89,7 +89,7 @@
     >
       <div class="kuiPromptForItems">
         <div class="kuiPromptForItems__message">
-          Looks like you don&rsquo;t have any dashboards. Let&rsquo;s add some!
+          Looks like you don&rsquo;t have any dashboards. Let&rsquo;s create some!
         </div>
 
         <div class="kuiPromptForItems__actions">
@@ -98,7 +98,7 @@
             href="#/dashboard/create"
           >
             <span class="kuiButton__icon kuiIcon fa-plus"></span>
-            Add a dashboard
+            Create a dashboard
           </a>
         </div>
       </div>

diff --git a/src/core_plugins/kibana/public/visualize/editor/editor.html b/src/core_plugins/kibana/public/visualize/editor/editor.html
@@ -6,7 +6,7 @@
       <!-- Breadcrumbs. -->
       <bread-crumbs
         data-transclude-slot="topLeftCorner"
-        title="getVisualizationTitle()"
+        page-title="getVisualizationTitle()"
         use-links="true"
         omit-current-page="true"
         omit-pages="['edit']"

diff --git a/src/core_plugins/kibana/public/visualize/listing/visualize_listing.html b/src/core_plugins/kibana/public/visualize/listing/visualize_listing.html
@@ -70,13 +70,38 @@
       </div>
     </div>
 
-    <!-- NoResults -->
-    <div class="kuiPanel kuiPanel--centered" ng-if="!listingController.items.length">
-      <div class="kuiNoResults">
+    <!-- NoItems -->
+    <div
+      class="kuiPanel kuiPanel--centered kuiPanel--withHeader"
+      ng-if="!listingController.items.length && listingController.filter"
+    >
+      <div class="kuiNoItems">
         No visualizations matched your search.
       </div>
     </div>
 
+    <!-- PromptForItems -->
+    <div
+      class="kuiPanel kuiPanel--centered kuiPanel--withHeader"
+      ng-if="!listingController.items.length && !listingController.filter"
+    >
+      <div class="kuiPromptForItems">
+        <div class="kuiPromptForItems__message">
+          Looks like you don&rsquo;t have any visualizations. Let&rsquo;s create some!
+        </div>
+
+        <div class="kuiPromptForItems__actions">
+          <a
+            class="kuiButton kuiButton--primary kuiButton--iconText"
+            href="#/visualize/new"
+          >
+            <span class="kuiButton__icon kuiIcon fa-plus"></span>
+            Create a visualization
+          </a>
+        </div>
+      </div>
+    </div>
+
     <!-- Table -->
     <table class="kuiTable" ng-if="listingController.items.length">
       <thead>

diff --git a/src/core_plugins/kibana/public/visualize/wizard/step_1.html b/src/core_plugins/kibana/public/visualize/wizard/step_1.html
@@ -6,6 +6,8 @@
     <bread-crumbs
       data-transclude-slot="topLeftCorner"
       use-links="true"
+      omit-current-page="true"
+      page-title="'New'"
     ></bread-crumbs>
   </div>
 </kbn-top-nav>

diff --git a/src/core_plugins/kibana/public/visualize/wizard/step_2.html b/src/core_plugins/kibana/public/visualize/wizard/step_2.html
@@ -6,6 +6,8 @@
     <bread-crumbs
       data-transclude-slot="topLeftCorner"
       use-links="true"
+      omit-current-page="true"
+      page-title="'Choose search source'"
     ></bread-crumbs>
   </div>
 </kbn-top-nav>